Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix touch interaction - adds correct reset value to startPosition #3138

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

til2000
Copy link
Contributor

@til2000 til2000 commented Jul 14, 2023

Cross-references to related issues.
Associated issues: #3137

Notes re. the content of the pull request.

This PR fixes an issue which occurs when using touch devices.

Checklist

Author:

  • The proper base branch has been selected. New features go on unstable. Bug-fix patches can go on either unstable or master.
  • N/A -- Automated tests have been included in this pull request, if possible, for the new feature(s) or bug fix. Check this box if tests are not pragmatically possible (e.g. rendering features could include screenshots or videos instead of automated tests).
  • The associated GitHub issues are included (above).
  • Notes have been included (above).

Reviewers:

  • All automated checks are passing (green check next to latest commit).
  • At least one reviewer has signed off on the pull request.
  • For bug fixes: Just after this pull request is merged, it should be applied to both the master branch and the unstable branch. Normally, this just requires cherry-picking the corresponding merge commit from master to unstable -- or vice versa.

@til2000 til2000 changed the title Update load-listeners.js - adds correct reset value Bugfix touch interaction - adds correct reset value to startPosition Jul 14, 2023
@til2000 til2000 changed the title Bugfix touch interaction - adds correct reset value to startPosition DRAFT - Bugfix touch interaction - adds correct reset value to startPosition Jul 14, 2023
@til2000 til2000 changed the title DRAFT - Bugfix touch interaction - adds correct reset value to startPosition Bugfix touch interaction - adds correct reset value to startPosition Jul 14, 2023
@maxkfranz maxkfranz self-requested a review July 18, 2023 16:52
@maxkfranz maxkfranz linked an issue Jul 18, 2023 that may be closed by this pull request
@maxkfranz
Copy link
Member

@til2000, thank you for the pull request. I'll try to set aside some time so that we can this merged and released soon.

@maxkfranz maxkfranz merged commit c09bd0e into cytoscape:master Jul 20, 2023
1 check passed
@maxkfranz
Copy link
Member

This isn't easily reproducible, but the mitigation seems as though it wouldn't cause any harm. Merged.

maxkfranz added a commit that referenced this pull request Jul 20, 2023
Bugfix touch interaction - adds correct reset value to startPosition
maxkfranz added a commit that referenced this pull request Jul 20, 2023
Cherry-pick: Merge pull request #3138 from til2000/fix-#3137

Bugfix touch interaction - adds correct reset value to startPosition
maxkfranz added a commit that referenced this pull request Jul 20, 2023
Cherry-pick: Merge pull request #3138 from til2000/fix-#3137

Bugfix touch interaction - adds correct reset value to startPosition
AkMo3 added a commit to AkMo3/cytoscape.js that referenced this pull request Aug 10, 2023
Cherry-pick: Merge pull request cytoscape#3138 from til2000/fix-#3137

Bugfix touch interaction - adds correct reset value to startPosition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset of startPosition leads to issues
2 participants