Test for changes in image output size (#27)

cyrilwanner · Jul 23, 2020 · feb3c8c · feb3c8c
1 parent 58e67c6
commit feb3c8c
Show file tree

Hide file tree

Showing 11 changed files with 28 additions and 224 deletions.
diff --git a/.github/bundlewatch.json b/.github/bundlewatch.json
@@ -6,6 +6,10 @@
  },
  {
  "path": "./packages/*/lib/**/*.!(wasm)"
+ },
+ {
+ "path": "./packages/*/__tests__/out/**/*.*",
+ "compression": "none"
  }
  ]
 }
diff --git a/.github/workflows/stats.yml b/.github/workflows/stats.yml
@@ -16,6 +16,8 @@ jobs:
  run: npm ci
  - name: Build
  run: npm run build
+ - name: Test
+ run: npm run test:sizes
  - uses: cyrilwanner/bundlewatch-comment-action@v1
  with:
  github-token: ${{ secrets.GITHUB_TOKEN }}

diff --git a/.gitignore b/.gitignore
@@ -13,4 +13,5 @@ lerna-debug.log*
 # project
 lib
 tmp
+out
 target
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -5,9 +5,9 @@
  "build": "lerna run build --parallel",
  "lint": "lerna run lint --parallel",
  "test": "lerna run test --parallel",
+ "test:sizes": "lerna run test:sizes --parallel",
  "postinstall": "lerna bootstrap",
- "lerna": "lerna",
- "bundlewatch": "bundlewatch --config .github/bundlewatch.json"
+ "lerna": "lerna"
  },
  "dependencies": {},
  "devDependencies": {
@@ -18,7 +18,6 @@
  "@types/jest": "^25.2.2",
  "@typescript-eslint/eslint-plugin": "^2.33.0",
  "@typescript-eslint/parser": "^2.33.0",
- "bundlewatch": "^0.2.7",
  "eslint": "^6.8.0",
  "eslint-config-airbnb-base": "^14.1.0",
  "eslint-config-prettier": "^6.11.0",

diff --git a/packages/mozjpeg/__tests__/index.test.ts b/packages/mozjpeg/__tests__/index.test.ts
@@ -14,7 +14,7 @@ describe('mozjpeg', () => {
  initTestUtils(__dirname);
  });
 
- afterAll(cleanup);
+ afterAll(() => cleanup());
 
  // test all image sizes
  ['tiny', 'small', 'medium', 'large'].forEach((size) => {

diff --git a/packages/mozjpeg/package.json b/packages/mozjpeg/package.json
@@ -22,7 +22,8 @@
  "lint": "tsc --noEmit && eslint . --ext .ts --ext .js",
  "lint:fix": "npm run lint -- --fix",
  "test": "jest",
- "test:watch": "npm test -- --watch"
+ "test:watch": "npm test -- --watch",
+ "test:sizes": "KEEP_IMAGE_OUTPUT=true jest --testPathIgnorePatterns '.*performance.*'"
  },
  "devDependencies": {
  "@babel/cli": "^7.8.4",

diff --git a/packages/oxipng/__tests__/index.test.ts b/packages/oxipng/__tests__/index.test.ts
@@ -13,7 +13,7 @@ describe('oxipng', () => {
  initTestUtils(__dirname);
  });
 
- afterAll(cleanup);
+ afterAll(() => cleanup());
 
  // test all image sizes
  ['tiny', 'small', 'medium', 'large'].forEach((size) => {

diff --git a/packages/oxipng/package.json b/packages/oxipng/package.json
@@ -22,7 +22,8 @@
  "lint": "tsc --noEmit && eslint . --ext .ts --ext .js",
  "lint:fix": "npm run lint -- --fix",
  "test": "jest",
- "test:watch": "npm test -- --watch"
+ "test:watch": "npm test -- --watch",
+ "test:sizes": "KEEP_IMAGE_OUTPUT=true jest --testPathIgnorePatterns '.*performance.*'"
  },
  "devDependencies": {
  "@babel/cli": "^7.8.4",

diff --git a/packages/test-utils/README.md b/packages/test-utils/README.md
@@ -45,10 +45,14 @@ Initializes the test utils by configuring internal paths.
 
 Path to the test root.
 
-### `cleanup(): void`
+### `cleanup(force?): void`
 
 Cleans up tests by removing temporary files and directories.
 
+##### `force?: boolean`
+
+If true, will forcefully remove the tmp directory, even if the `KEEP_IMAGE_OUTPUT` env variable is set.
+
 ### `async getImage(fileName): { data: Buffer; info: OutputInfo }`
 
 Loads an image file and returns its buffer and information.