Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dangling commas from function params to support node v6.14 #25

Merged

Conversation

eleith
Copy link
Contributor

@eleith eleith commented May 22, 2018

fixes #24 by removing two dangling commas on functional arguments

@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #25   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          44     44           
  Branches       13     13           
=====================================
  Hits           44     44
Impacted Files Coverage Δ
index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2517dc6...dec9124. Read the comment docs.

@cyrilwanner
Copy link
Owner

Strange, I would have expected travis to fail as I'm also running tests on node 6 there. I guess I have to check the test & travis setup again..

Thank you very much for pointing out this issue and for fixing it @eleith! 🎉

@cyrilwanner cyrilwanner merged commit 2f17574 into cyrilwanner:master May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support node v6
2 participants