Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undeterminist detected loaders #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guillaumeLamanda
Copy link

@guillaumeLamanda guillaumeLamanda commented Nov 15, 2020

Fix the issue I ran into when upgrading my project to NextJS 10.

I Added more information in my comment on #219.

Not sure it totally close it, but the initial comment on the issue is unclear...

About the change, I think the path resolution was too restrictive and too sharp specific.
I updated the adapter condition and adapter path resolution. All checks are OK.

@codecov-io
Copy link

codecov-io commented Nov 15, 2020

Codecov Report

Merging #220 (bfc875e) into master (fe31e5c) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   88.42%   88.42%           
=======================================
  Files          13       13           
  Lines         190      190           
  Branches       46       46           
=======================================
  Hits          168      168           
  Misses         16       16           
  Partials        6        6           
Impacted Files Coverage Δ
lib/loaders/responsive-loader.js 72.72% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe31e5c...bfc875e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants