Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optimizeImages configuration #115

Merged

Conversation

andysaman
Copy link
Contributor

@andysaman andysaman commented Oct 21, 2019

Resolved Issue #110:

  • This adds the ability to skip optimization during production builds if desired.

@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #115 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #115   +/-   ##
======================================
  Coverage    90.9%   90.9%           
======================================
  Files          13      13           
  Lines         176     176           
  Branches       41      41           
======================================
  Hits          160     160           
  Misses         13      13           
  Partials        3       3
Impacted Files Coverage Δ
lib/index.js 94.73% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc0c476...0a25352. Read the comment docs.

@cyrilwanner
Copy link
Owner

Initially, this config value was only meant to disable the warning, but it makes total sense to actually disable the optimization.
Thank you very much for your contribution! This fix will be published to npm in a few minutes.

@cyrilwanner cyrilwanner changed the title Issue #110 - Configuration optimizeImages bugfix Fix optimizeImages configuration Nov 1, 2019
@cyrilwanner cyrilwanner merged commit 97526e5 into cyrilwanner:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants