Skip to content

Commit

Permalink
chore: move frontend-shared from a dev dependency to a runtime depend…
Browse files Browse the repository at this point in the history
…ency in launchpad package.json (#29783)

* build: move frontend-shared from a dev dependency to a runtime dependency in launchpad package.json

* bmp

* add darwin workflow

* move frontend-shared back to dev dependency in launchpad, declare as nx implicit dep
  • Loading branch information
cacieprins committed Jul 1, 2024
1 parent 10f90f9 commit a16edd5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .circleci/cache-version.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Bump this version to force CI to re-create the cache from scratch.

06-07-24
07-01-24
3 changes: 2 additions & 1 deletion .circleci/workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ mainBuildFilters: &mainBuildFilters
- /^release\/\d+\.\d+\.\d+$/
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- 'update-v8-snapshot-cache-on-develop'
- 'ignore-chrom-prefs'
- 'investigate/darwin-ci-build-order'
- 'publish-binary'
- 'angular-signals-ct-harness'

Expand All @@ -44,6 +44,7 @@ macWorkflowFilters: &darwin-workflow-filters
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
- equal: [ 'angular-signals-ct-harness', << pipeline.git.branch >> ]
- equal: [ 'investigate/darwin-ci-build-order', << pipeline.git.branch >> ]
- matches:
pattern: /^release\/\d+\.\d+\.\d+$/
value: << pipeline.git.branch >>
Expand Down
3 changes: 2 additions & 1 deletion packages/launchpad/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@
],
"nx": {
"implicitDependencies": [
"@packages/graphql"
"@packages/graphql",
"@packages/frontend-shared"
]
}
}

5 comments on commit a16edd5

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on a16edd5 Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.13.0/linux-x64/develop-a16edd56903e32da598d07c0c8d0e835d060396a/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on a16edd5 Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.13.0/linux-arm64/develop-a16edd56903e32da598d07c0c8d0e835d060396a/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on a16edd5 Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.13.0/win32-x64/develop-a16edd56903e32da598d07c0c8d0e835d060396a/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on a16edd5 Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.13.0/darwin-arm64/develop-a16edd56903e32da598d07c0c8d0e835d060396a/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on a16edd5 Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.13.0/darwin-x64/develop-a16edd56903e32da598d07c0c8d0e835d060396a/cypress.tgz

Please sign in to comment.