lookup: handle // and trailing slash components correctly #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we hit empty components, we need to treat them as though they are a "." component. We could skip them for non-trailing components but for trailing components it's critical to actually try to do the open so that we get openat2-like errors for non-directory states. For the single trailing slash case, it's simpler to implement it as a final "." open after we've done the other lookups (we could switch to using an array of path component like libpathrs does, but this is a simpler change). Signed-off-by: Aleksa Sarai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we hit empty components, we need to treat them as though they are a "." component. We could skip them for non-trailing components but for trailing components it's critical to actually try to do the open so that we get openat2-like errors for non-directory states.
For the single trailing slash case, it's simpler to implement it as a final "." open after we've done the other lookups (we could switch to using an array of path component like libpathrs does, but this is a simpler change).
Signed-off-by: Aleksa Sarai [email protected]