Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ggplot and grid fixes #452

Merged
merged 11 commits into from
Jul 6, 2024
Merged

ggplot and grid fixes #452

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
73e4f25
construct the default argument in coord_cartesian()
moodymudskipper Jul 6, 2024
a185d29
bypass `/` that failed when compressing simpleUnit
moodymudskipper Jul 6, 2024
0da3b0b
treat "simpleUnit" a grid class, not a base class, and add grid as a …
moodymudskipper Jul 6, 2024
5ef894a
Fix is_corrupted_simpleUnit()
moodymudskipper Jul 6, 2024
1782daf
Fix fallback for ScalesList
moodymudskipper Jul 6, 2024
5c47f98
remove attributes in format_rep() to avoid repairing twice
moodymudskipper Jul 6, 2024
7e93022
add tests for simpleUnit
moodymudskipper Jul 6, 2024
5d7973c
rename files
moodymudskipper Jul 6, 2024
d1d5a36
Merge branch 'main' into f-ggplot-and-grid-fixes
moodymudskipper Jul 6, 2024
7418559
Update NEWS
moodymudskipper Jul 6, 2024
cca36e5
chore: Auto-update from GitHub Actions
moodymudskipper Jul 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix fallback for ScalesList
  • Loading branch information
@moodymudskipper
moodymudskipper committed Jul 6, 2024
commit 1782daf5924765bec1be438a0a0efa395e785a5e
2 changes: 1 addition & 1 deletion R/s3-ggplot2-ScalesList.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ is_corrupted_ScalesList <- function(x) {
#' @method .cstr_construct.ScalesList ScalesList
.cstr_construct.ScalesList.ScalesList <- function(x, ...) {
# FIXME: appropriate constructors
if (!length(x$scales)) return(NextMethod(x))
if (!length(x$scales)) return(.cstr_construct.ScalesList.environment(x, ...))
scales_chr <- lapply(x$scales, function(x, ...) .cstr_construct(x, ...), ...)
if (length(x$scales) == 1) return(scales_chr[[1]])
Reduce(function(x, y) .cstr_pipe(x, y, pipe = "plus", indent = FALSE), scales_chr)
Expand Down