Properly log errors that are presented as alerts #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
commented
Oct 25, 2023
| import Alert from '@/model/Alert.model' | ||
| import { Alert } from '@/model/Alert.model' |
There was a problem hiding this comment.
Non-functional change. For some reason the type recognition in VSCode wasn't working for a default export. So that's why I've changed it
MetRonnie
commented
Oct 25, 2023
| @@ -106,6 +106,8 @@ describe('User Profile', () => { | |||
| }) | |||
| // Close menu: | |||
| .get('noscript').click({ force: true }) | |||
| .get('@mutationMenu') | |||
| .should('not.be.visible') | |||
There was a problem hiding this comment.
Attempt at fixing flaky test failing on FF with
ResizeObserver loop completed with undelivered notifications.
Based on https://stackoverflow.com/a/76784540/3217306
ResizeObserver is often used to provide animation, so once you find the line that causes the error, add a visibility check to allow the page to settle before testing
oliver-sanders
approved these changes
Oct 26, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to view the stack trace for caught errors
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.CHANGES.mdentry included (invisible to users)