Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow: open new tabs on top #1177

Merged
merged 2 commits into from
Dec 22, 2022
Merged

workflow: open new tabs on top #1177

merged 2 commits into from
Dec 22, 2022

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Dec 21, 2022 •
edited
Loading

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.
  • No documentation update required.

@oliver-sanders oliver-sanders added small UX/UI User experience and interface improvements labels Dec 21, 2022
@oliver-sanders oliver-sanders added this to the 1.4.0 milestone Dec 21, 2022
@oliver-sanders oliver-sanders self-assigned this Dec 21, 2022
@oliver-sanders
workflow: open new tabs on top
8923055 
* Closes cylc#1090
* When a new tab (i.e. Cylc view) is opened it should be acitvated
  (i.e. put on top).
MetRonnie
MetRonnie approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Just 1 commented out line leftover)

src/components/cylc/workflow/Lumino.vue Outdated Show resolved Hide resolved
@MetRonnie MetRonnie merged commit 2d97cd5 into cylc:master Dec 22, 2022
@oliver-sanders oliver-sanders deleted the open-view-in-new-tab branch December 22, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
small UX/UI User experience and interface improvements
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

lumino: open new tabs on top
2 participants
@oliver-sanders @MetRonnie