Fix miniupnpc versioning. #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had that same problem with CBigNum/BIGNUM. I believe that went away when I specifically installed libssl1.0-dev (still available on ubuntu 18.10) |
|
@cdberkstresser Thanks, that worked to get it compiling on WSL (with libupnp 1.9), so it's compile tested against Ubuntu 18.04. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #40.
I just used the API versioning that's in miniupnpc. It's worth noting that the header was changed back in 2015, so 2.0 is also affected.
I couldn't compile-test as I could find any compiler that accepted the CBigNum* to BIGNUM* implicit conversions, whether Ubuntu 18.04, MingW, or anything else.