Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render landuse=retail and shop=mall names #537

Merged
merged 5 commits into from
Mar 23, 2021
Merged

Conversation

@Phyks Phyks mentioned this pull request Mar 21, 2021
@Florimondable
Copy link
Member

I thought you wanted to change the landuse background color ?

@Phyks
Copy link
Member Author

Phyks commented Mar 21, 2021 via email

@Florimondable
Copy link
Member

@commercial:        @land * 0.97;
@industrial:        @land * 0.96;

Hard to see the differences ':).

I'd be ok to change the color to have something different, maybe grey or the red color like osm-carto ? Commercial areas is much more usefull to know than industrial areas, I think.

@Phyks
Copy link
Member Author

Phyks commented Mar 21, 2021

@Florimondable
Copy link
Member

Ok, I think the red conflict too much with the military landuse color.

I tried, light purple #ded8dd
Screenshot_20210322_220000

And a grey #d6d6d6
Screenshot_20210322_220251

I think both work, what do you think ?

@Phyks
Copy link
Member Author

Phyks commented Mar 22, 2021

Indeed! Slight preference for the light purple on my side, which seems to convey a bit more semantic than just plain grey. PR is updated with conflict resolution and light purple.

@Florimondable Florimondable merged commit 4fed093 into master Mar 23, 2021
@quasart
Copy link
Contributor

quasart commented Mar 28, 2021

Hello, I think it's good idea to use a light color instead of grey, but why purple ?

I though purple means cycling-related amenities ? (cycling track, routes, bicycle shops, compressed air)

Why not try light brown instead ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commercial areas are not easy to spot
3 participants