Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render road ref along them, smaller cycle route shield, cleaning #233

Merged
merged 9 commits into from
Dec 1, 2019

Conversation

Florimondable
Copy link
Member

link to #197

cyclosm_road_route_ref_city
cyclosm_road_names_country

}
}

#roads-text-ref {
[highway = 'motorway_trunk'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two of them were merged https://github.com/cyclosm/cyclosm-cartocss-style/blob/master/project.mml#L2011 in SQL queries. We should either keep motorway_trunk or drop the merge in roads-text-ref SQL.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t remind to have done that change, must come from the copy past I have done to write that layer from name layer.

labels.mss Show resolved Hide resolved
@@ -629,6 +521,7 @@
shield-face-name: @sans;
shield-clip: @shield-clip;
shield-file: url("symbols/shields/[type]_[width]x[height].svg");
shield-transform: "scale(0.75)";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather edit the script https://github.com/cyclosm/cyclosm-cartocss-style/blob/master/scripts/generate_shields.py to generate shield the right size. I'll handle this after this PR has been merged.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, I failed 😭

project.mml Show resolved Hide resolved
@Phyks
Copy link
Member

Phyks commented Nov 8, 2019

👍

We have a bit of readability issues at low zooms (city or less).

https://cyclosm.org/#13/48.8779/2.2867

Screenshot_2019-11-08 CyclOSM — Kosmtik

https://cyclosm.org/#11/48.8401/2.0098

Screenshot_2019-11-08 CyclOSM — Kosmtik 2

@Florimondable
Copy link
Member Author

Florimondable commented Nov 8, 2019

We have a bit of readability issues at low zooms (city or less).

May be, not sure, +1 to the font size ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants