Render path with bicycle=designated almost as a cycleway and segregated as a cycleway #184

Florimondable · 2019-09-26T20:41:22Z

link to #143 (but not completed yet, segregated must be done also)

Can't be able to fix the oneway arrow not rendered issue on path with oneway:bicycle=yes

…and with a mixed pedestrian blue color

Phyks · 2019-09-27T08:13:12Z

Can't be able to fix the oneway arrow not rendered issue on path with oneway:bicycle=yes

Here is the fix I think Phyks@5f29c76.

Phyks · 2019-09-27T08:22:29Z

By the way, could you post before/after pictures (or the URL used, so I can go and check the before on cyclosm.org easily)? Thanks!

Fix use white color for oneway arrow with path.

…egregated=yes.

Florimondable · 2019-09-28T21:51:37Z

Before (bicycle=designated only) :

After

higway=path bicycle=designated segregated=yes : draw a cycleway with a right outline as a path

higway=footway bicycle=designated segregated=yes : draw a cycleway with a right outline as a footway

Dardy87 · 2019-09-29T03:19:21Z

Are you sure on the last example? in my opinion higway=footway bicycle=designated segregated=yes
Is a wrong tagging (even if I found it in some cases, but usually I fix it).
Otherwise also the schema higway=cycleway foot=designated segregated=yes should be valid (but I repeat, for me it's wrong).

Mixed cycleways and footway should be tagged as paths. Is it specified in some wiki that maybe I miss?

Florimondable · 2019-09-29T13:43:02Z

@Dardy87 I agree with you it is bad tagging.
But I was wondering if it's a scheme use a lot or not.
After few overpass request around the word i seems it's not wildly used, so we can remove it.

Florimondable · 2019-09-29T13:46:34Z

We should remove also special rendering with highway=footway/bridelway and bicycle=designated, it's bad tagging also and we should not promote bad tagging.

…ging. Still keep footway and bridleway as path if bicycle=yes.

Phyks · 2019-09-30T14:36:02Z

way[highway=footway][bicycle=designated] is a bad tagging (up to 7% of the highway=footway though, https://taginfo.openstreetmap.org/tags/highway=footway#combinations) and is checked by the JOSM validator and Osmose (https://github.com/osm-fr/osmose-backend/blob/ff294d7b5f6289b968d7165e6246f870e46c846a/plugins/Josm_combinations.py#L1461-L1462).

way[highway=bridleway][bicycle=designated] is probably as well although it's much more common (up to 29% of bridleways, https://taginfo.openstreetmap.org/tags/highway=bridleway#combinations) and not checked by any validation tools. I agree this is bad tagging though and I'll try to submit a patch for extra checking in JOSM etc.

labels.mss

Phyks · 2019-09-30T14:41:15Z

labels.mss

- }
- [highway='cycleway'] {
+ [highway='cycleway'],
+ [highway='path'] {


It might be better to have an is_primary_bike value exported in the SQL output and filter on this one. This one, we could also account for some bicycle=designated cases or roads without motor traffic.

Might also be better in terms of Mapnik XML file size / etc.

is_primary_bike for what tags combination ?

Phyks · 2019-09-30T14:42:33Z

project.mml

+ ELSE 'no'
+ END AS segregated,
+ CASE
+ WHEN tags->'oneway:bicycle' IN ('yes', '-1') THEN 'yes'


THEN tags->'oneway:bicycle' to keep the direction, or we will never need it?

I don't understand the question.

Phyks · 2019-09-30T14:42:45Z

project.mml

+ ELSE 'no'
+ END AS segregated,
+ CASE
+ WHEN tags->'oneway:bicycle' IN ('yes', '-1') THEN 'yes'


THEN tags->'oneway:bicycle' to keep the direction, or we will never need it?

Phyks · 2019-09-30T14:43:30Z

project.mml

+ ELSE 'no'
+ END AS segregated,
+ CASE
+ WHEN tags->'oneway:bicycle' IN ('yes', '-1') THEN 'yes'


THEN tags->'oneway:bicycle' to keep the direction, or we will never need it?

Phyks · 2019-09-30T14:43:38Z

project.mml

@@ -1987,8 +2023,7 @@ Layer:
 ELSE 'no'
 END AS oneway,
 CASE
- WHEN tags->'oneway:bicycle'='no' THEN 'no'
- WHEN tags->'oneway:bicycle'='yes' THEN 'yes'
+ WHEN tags->'oneway:bicycle' IN ('yes', '-1') THEN 'yes'


THEN tags->'oneway:bicycle' to keep the direction, or we will never need it?

Phyks · 2019-09-30T14:48:21Z

roads.mss

 line-width: @rdz17_cycle;
- [oneway='no'] { line-width: @rdz17_cycle*1.5; }
+ [oneway='no'][oneway_bicycle='no']


We should probably try to avoid this double check here. I should review the exact tags we need, but probably we could fill in the oneway_bicycle value with the oneway value by default, therefore having:

oneway which would be the general traffic oneway

oneway_bicycle which would be the real oneway status for bikes

Phyks · 2019-09-30T14:49:19Z

roads.mss

 line-width: @rdz12_path;
 }
- [type='cycleway'] {
+ [type='cycleway'],
+ [type='path'][designated='yes'] {


We have designated, segregated and other tags exported. Not sure but we could probably factor them together. :/

Florimondable · 2019-09-30T15:24:23Z

way[highway=footway][bicycle=designated] is a bad tagging (up to 7% of the highway=footway though, https://taginfo.openstreetmap.org/tags/highway=footway#combinations)

I read 0.32% of footways have also bicycle=designated, so not much.

way[highway=bridleway][bicycle=designated] is probably as well although it's much more common (up to 29% of bridleways, https://taginfo.openstreetmap.org/tags/highway=bridleway#combinations)

I read 3.3% of bridleways have also bicycle=designated, so not much.

Phyks · 2019-10-01T10:02:15Z

Indeed, I missed the fact that we could get stats on bicycle=designated exactly. That's perfectly fine then!

quasart · 2019-10-03T17:53:46Z

Nice ! Many useful path have been enhanced, thank you

Florimondable added 2 commits September 26, 2019 21:10

Add bicycle=designated for paths, render them as large as a cycleway …

8fab5c9

…and with a mixed pedestrian blue color

Manage oneway width for path.

4e9d4ac

Florimondable added 3 commits September 28, 2019 21:58

Fix oneway arrow on path for cyclist only.

72c0c3a

Fix use white color for oneway arrow with path.

Render in cyleway blue shared path with bicycle with segregation.

18ec133

Add right outline for path/footway/bridleway bicycle=designated and s…

1c83299

…egregated=yes.

Florimondable changed the title ~~Render path with bicycle=designated almost as a cycleway~~ Render path with bicycle=designated almost as a cycleway and segregated as a cycleway Sep 28, 2019

Remove footway and bridleway rendered as cycle track to avoid bad tag…

f19f8b1

…ging. Still keep footway and bridleway as path if bicycle=yes.

Phyks reviewed Sep 30, 2019

View reviewed changes

Phyks added a commit that referenced this pull request Oct 1, 2019

Few enhancements after #184

1811f0c

Phyks merged commit f19f8b1 into cyclosm:master Oct 1, 2019

Phyks added a commit to cyclosm/cyclosm-website that referenced this pull request Oct 1, 2019

Update legend after cyclosm/cyclosm-cartocss-style#184

4ccc097

Phyks mentioned this pull request Oct 2, 2019

Path with bicycle=designated #143

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Render path with bicycle=designated almost as a cycleway and segregated as a cycleway #184

Render path with bicycle=designated almost as a cycleway and segregated as a cycleway #184

Florimondable commented Sep 26, 2019

Phyks commented Sep 27, 2019 •

edited

Loading

Phyks commented Sep 27, 2019

Florimondable commented Sep 28, 2019

Dardy87 commented Sep 29, 2019 •

edited

Loading

Florimondable commented Sep 29, 2019

Florimondable commented Sep 29, 2019

Phyks commented Sep 30, 2019

Phyks Sep 30, 2019

Florimondable Sep 30, 2019

Phyks Sep 30, 2019

Florimondable Sep 30, 2019

Phyks Sep 30, 2019

Phyks Sep 30, 2019

Phyks Sep 30, 2019

Phyks Sep 30, 2019

Phyks Sep 30, 2019

Florimondable commented Sep 30, 2019

Phyks commented Oct 1, 2019

quasart commented Oct 3, 2019

Render path with bicycle=designated almost as a cycleway and segregated as a cycleway #184

Render path with bicycle=designated almost as a cycleway and segregated as a cycleway #184

Conversation

Florimondable commented Sep 26, 2019

Phyks commented Sep 27, 2019 • edited Loading

Phyks commented Sep 27, 2019

Florimondable commented Sep 28, 2019

Dardy87 commented Sep 29, 2019 • edited Loading

Florimondable commented Sep 29, 2019

Florimondable commented Sep 29, 2019

Phyks commented Sep 30, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Florimondable commented Sep 30, 2019

Phyks commented Oct 1, 2019

quasart commented Oct 3, 2019

Phyks commented Sep 27, 2019 •

edited

Loading

Dardy87 commented Sep 29, 2019 •

edited

Loading