Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions last color merge #363

Closed
Florimondable opened this issue May 12, 2020 · 10 comments
Closed

Regressions last color merge #363

Florimondable opened this issue May 12, 2020 · 10 comments
Labels
bug Something isn't working

Comments

@Florimondable
Copy link
Member

  1. After reading the code MTB routes should be no more rendered in orange at lower zooms.

  2. Lucas Verney(s’ouvre dans un nouvel onglet) 18 h 52
    je viens de voir sur https://user-images.githubusercontent.com/47089717/80147216-77933e00-85b3-11ea-8b3b-470dda268eab.png, on n'a pas cassé les area pedestrian (le fond gris) ?

@Florimondable
Copy link
Member Author

In the following picture I see two blue dots on Rivoli (left part), happen only at z15 at some places.
Due to bicycle=designated arrows ?

15-48 85889-2 34765-optimroads2

@Florimondable
Copy link
Member Author

1. After reading the code MTB routes should be no more rendered in orange at lower zooms.

Should be fixed.

2. Lucas Verney(s’ouvre dans un nouvel onglet)  18 h 52
   je viens de voir sur https://user-images.githubusercontent.com/47089717/80147216-77933e00-85b3-11ea-8b3b-470dda268eab.png, on n'a pas cassé les area pedestrian (le fond gris) ?

Yes, I don't get what's the problem, there are all multipolygon, the code didn't change

@Phyks Phyks added the bug Something isn't working label May 18, 2020
@Phyks
Copy link
Member

Phyks commented May 19, 2020

Probably an invalid geometry at some point. Seems this is fixed https://www.cyclosm.org/#map=18/48.87362/2.29575/cyclosm.

@Phyks Phyks closed this as completed May 19, 2020
@Florimondable
Copy link
Member Author

No, it's not fixed in the current master, the problem was from the branch not the current prod release.

@Phyks Phyks reopened this May 19, 2020
@Phyks
Copy link
Member

Phyks commented May 20, 2020

I double checked with the current master after the merges. This is indeed fixed. I added 6b7f55b to filter out underground buildings.

This can be seen across the square, due to building=transportation on the underground platforms: https://www.cyclosm.org/#map=19/48.87442/2.29530/cyclosm.

@Phyks Phyks closed this as completed May 20, 2020
@Phyks
Copy link
Member

Phyks commented May 20, 2020

I had a typo, fixed in 29b60ac.

@Florimondable
Copy link
Member Author

is this one fixed ? #363 (comment)

@Phyks
Copy link
Member

Phyks commented May 21, 2020

Missed it. This one is not fixed yet:

Screenshot_2020-05-21 CyclOSM — Kosmtik

@Phyks
Copy link
Member

Phyks commented May 23, 2020

Fixed in 433884e.

@Phyks Phyks closed this as completed May 23, 2020
@Florimondable
Copy link
Member Author

Merci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants