Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wind turbine are no rendered #267

Closed
Florimondable opened this issue Dec 26, 2019 · 3 comments
Closed

Wind turbine are no rendered #267

Florimondable opened this issue Dec 26, 2019 · 3 comments
Labels
bug Something isn't working high zooms Issues affecting high zoom levels

Comments

@Florimondable
Copy link
Member

see https://www.cyclosm.org/#map=16/49.6858/3.9501/cyclosm

generator:method=wind_turbine
generator:source=wind
power=generator
@Florimondable
Copy link
Member Author

Windmill either
https://www.cyclosm.org/#map=19/48.88737/2.33676/cyclosm

@Phyks Phyks added enhancement An already rendered feature which should be improved. good first issue Good for newcomers high zooms Issues affecting high zoom levels labels Jan 23, 2020
@Phyks Phyks added bug Something isn't working and removed enhancement An already rendered feature which should be improved. good first issue Good for newcomers labels Mar 18, 2020
@Phyks
Copy link
Member

Phyks commented Mar 18, 2020

It should be rendered https://github.com/cyclosm/cyclosm-cartocss-style/blob/master/amenities.mss#L612-L628.

This is definitely a bug, but I cannot find what is wrong at the moment... :/

Phyks added a commit that referenced this issue Apr 26, 2020
@Phyks
Fix amenities render, render windmill and wind turbine. See #267.
786c901
@Phyks
Copy link
Member

Phyks commented Apr 26, 2020

Fixed.

Windmill was not rendered because it was a tourism=attraction as well (not rendered though) which had superior precedence.

Wind turbine was not rendered due to a typo. Tag generator:source is in a dedicated column, not in the tags field.

@Phyks Phyks closed this as completed Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high zooms Issues affecting high zoom levels
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Phyks @Florimondable