Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render arrows for oriented bicycle routes #201

Closed
Phyks opened this issue Oct 6, 2019 · 3 comments
Closed

Render arrows for oriented bicycle routes #201

Phyks opened this issue Oct 6, 2019 · 3 comments
Labels
enhancement An already rendered feature which should be improved.
Milestone

Comments

@Phyks
Copy link
Member

Phyks commented Oct 6, 2019

Opacity instruction cannot be applied on a per-zoom level, see ce3fc7e.

To actually get the render we were expected, we would need to split the bicycle routes layers into per-zoom layers and apply different opacity.

Related to #131, #160 and #182. My opinion on this is we should rework these in depths:

  • Bicycle routes should be displayed at low zoom with quite strong color to be well visible.
  • They should start to fade out at Z9/Z10.
  • At something like Z14 they should just provide a halo on the side of the road to make it visible for anyone actively looking for them (therefore rendered below the road with a slightly larger width). Opacity and overlapping would be much easier to handle, we would not mind a stronger halo.
  • No need for arrows, see Render oneway cycle routes with arrows? #131 as these would only be visible at high zoom were the cycle route is actually not much visible. Arrows and directions are easy to infer from the rest of the items (infra / directions of traffic) and someone really looking into them will anyways use a GPX or a layer.

@Florimondable what do you think about this plan?

@Phyks Phyks added the bug Something isn't working label Oct 6, 2019
@Phyks Phyks added this to the v0.3 milestone Oct 6, 2019
@Florimondable
Copy link
Member

«At something like Z14 they should just provide a halo on the side of the road to make it visible for anyone actively looking for them (therefore rendered below the road with a slightly larger width). Opacity and overlapping would be much easier to handle, we would not mind a stronger halo.»
I don't think changing the way routes are rendered will look good when switching zoom levels.

I disagree, we still need the direction of the routes at medium-high zooms.

@Phyks
Copy link
Member Author

Phyks commented Oct 13, 2019

Most of the current issues should have been solved in dd53e0c. Still some fine-tuning to do probably and the question of arrows for direction.

@Phyks Phyks added the pending label Oct 15, 2019
@Phyks Phyks removed the pending label Nov 21, 2019
@Phyks Phyks modified the milestones: v0.3, v0.4 Nov 21, 2019
@Phyks Phyks changed the title Bicycle route nightmare Render arrows for oriented bicycle routes Nov 21, 2019
@Phyks Phyks added enhancement An already rendered feature which should be improved. and removed bug Something isn't working labels Dec 1, 2019
@Phyks
Copy link
Member Author

Phyks commented Mar 18, 2020

Duplicate of #131. Closing this one.

@Phyks Phyks closed this as completed Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An already rendered feature which should be improved.
Projects
None yet
Development

No branches or pull requests

2 participants