Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render ATM #149

Closed
Phyks opened this issue Jul 30, 2019 · 5 comments
Closed

Render ATM #149

Phyks opened this issue Jul 30, 2019 · 5 comments
Labels
enhancement An already rendered feature which should be improved. good first issue Good for newcomers
Milestone

Comments

@Phyks
Copy link
Member

Phyks commented Jul 30, 2019

atm=yes or amenity=atm

@Phyks Phyks added good first issue Good for newcomers enhancement An already rendered feature which should be improved. labels Jul 30, 2019
@Phyks Phyks added this to the v0.3 milestone Oct 4, 2019
@Phyks
Copy link
Member Author

Phyks commented Oct 7, 2019

Bank now rendered at Z18. ATM (amenity=atm) rendered at Z19. Discarded atm=yes so far since it seems to be almost exclusively used on banks / post offices.

@Phyks Phyks closed this as completed Oct 7, 2019
Phyks added a commit that referenced this issue Oct 7, 2019
@Florimondable
Copy link
Member

For the moment I would like to avoid making Z19 special cases, more zoom level is more work.
For ATM I think they are as important as restaurant and should be seen at least from Z18.

@Phyks
Copy link
Member Author

Phyks commented Oct 8, 2019

For ATM I think they are as important as restaurant and should be seen at least from Z18.

Actually, they are a refinement of amenity=bank. See https://www.openstreetmap.org/#map=18/48.81846/2.31864 (bank at Z18) and https://www.openstreetmap.org/#map=19/48.81842/2.31886 (bank + atm at Z19).

Moreover, Z18 is not a large zoom. We go up to 20 on cyclosm.org, we really need this in urban areas I think.

@Florimondable
Copy link
Member

No they are not a refinement, many countries have just small ATM everywhere and not next to a bank office.

@Phyks
Copy link
Member Author

Phyks commented Oct 8, 2019

many countries have just small ATM everywhere and not next to a bank office.

In my experience (US + Iceland), ATMs are almost always in a larger shop. Typically, you know you should be looking for supermarkets / convenience stores and they'll likely have an ATM. Therefore, I'd consider the larger shop (supermarket / convenience for instance) the thing to be rendered and the ATM would be a subfeature upon zooming in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An already rendered feature which should be improved. good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants