Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remembering selected mode and title format #31

Closed
Shadester opened this issue Jan 20, 2021 · 3 comments
Closed

Remembering selected mode and title format #31

Shadester opened this issue Jan 20, 2021 · 3 comments

Comments

@Shadester
Copy link
Contributor

Not sure if you think that this is a good idea, but I feel like I usually do SP recording, so for me, having the SP selected by default makes sense. What could be done is using localStorage to store the setting for mode and title, so it will remember what you used last.

@cybercase
Copy link
Owner

@Shadester Yes, I think this could be useful.

I've already implemented a similar localStorage-based mechanism for a few settings like:

I can easily do the same for the recording format here: https://github.com/cybercase/webminidisc/blob/master/src/redux/convert-dialog-feature.ts#L30

@Shadester
Copy link
Contributor Author

Shadester commented Jan 20, 2021

Ooh.. Cool. Then it would be like a two liner :)

cybercase added a commit that referenced this issue Jan 20, 2021
@Shadester
Copy link
Contributor Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants