Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simple explanation about test cases #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sssvip
Copy link

@sssvip sssvip commented Dec 20, 2017

add simple explanation about test cases, very useful for golang fresher

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@coveralls
Copy link

coveralls commented Dec 20, 2017

Coverage Status

Coverage remained the same at 95.76% when pulling 2302427 on sssvip:master into 651680c on cweill:master.

@cweill cweill self-requested a review March 16, 2018 04:27
@cweill
Copy link
Owner

cweill commented Mar 21, 2018

I agree that it would be a better UX to add some examples of how this works. I'll need to think about this a bit. We need to at least clean up the examples a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants