Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force refresh after excecute chore service #41

Merged
merged 2 commits into from
Jan 8, 2020
Merged

force refresh after excecute chore service #41

merged 2 commits into from
Jan 8, 2020

Conversation

BlueBlueBlob
Copy link
Contributor

Fix #40

custom_components/grocy/__init__.py Outdated Show resolved Hide resolved
custom_components/grocy/__init__.py Outdated Show resolved Hide resolved
custom_components/grocy/__init__.py Outdated Show resolved Hide resolved
@SebRut
Copy link
Collaborator

SebRut commented Jan 8, 2020

as a side note, do you think it would make sense to implement this for other services we provide as well?

@BlueBlueBlob
Copy link
Contributor Author

Thanks to speak about.
From my point of view, product requests take to long to refresh.
But actually, I have just changed the refresh order, because db changed time changes on PUT request, so all sensors are refreshed.

I'm waiting a feature from Grocy to optimize refresh data. And if nobody complain about it...

Btw for me, when I'm in Grocy UI, every change slows UI experience :/
I think we need to implement some caching data. But I don't how to with Grocy API.

Sorry for this long side note ;)

@BlueBlueBlob
Copy link
Contributor Author

@SebRut
Copy link
Collaborator

SebRut commented Jan 8, 2020

are all issues resolved so I can merge this?

@BlueBlueBlob
Copy link
Contributor Author

Yes

@SebRut SebRut merged commit c60a79e into custom-components:develop Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grocy services do not immediately update related sensor(s)
2 participants