-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge master into config flow. config flow : tested #22
merge master into config flow. config flow : tested #22
Conversation
I have something big incoming. I will post some screenshots ;) |
Enjoy :) |
I think config_flow is done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess get_mac() is unique to the machine running HA, we need a unique id for the grocy instance.
My core.entity_registry from HA :
Sorry I don't understand "unique for Grocy instance" |
Sorry for that late reply. if I understand correctly, the unique id should identify one entity uniquely. In our case the id should identify a sensor and it's corresponding grocy instance. This means 2 chores sensors for different grocy instances should have different ids but the id of one specific sensor should never change. |
Like [sensor name] + [ sensor type] + get_mac() ? |
That would still lead to 2 different grocy instances in the same HA instance having the same id, as the mac is HA host dependent. |
Ok sorry I just understand : it needs to work with multiple grocy instances. |
hashed api key (maybe in combination with uri) sounds like the best we can up with atm, as the api doesn't provide a way of identifying itselft. |
URL or URI (but I guess it's the URL and uri can be an URL) SomeHash(API-Key + url ) ? |
I guess md5 of api key should be fine |
Tested :)
And super fancy