Skip to content

Commit

Permalink
maint: update to latest gnulib
Browse files Browse the repository at this point in the history
Pulls in several portability fixes, including the fact that gnulib
now only works on platforms with two's complement signed integers.
Also makes for a smaller delta on the next update (we are waiting
on a license change to unsetenv for the sake of mingw).

* .gnulib: Update to latest.
* bootstrap: Resync from upstream.
* tests/virstringtest.c: Drop use of obsolete probes of integer
properties.

Signed-off-by: Eric Blake <[email protected]>
  • Loading branch information
ebblake committed May 26, 2016
1 parent 3ef5e21 commit 0cd6488
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .gnulib
Submodule .gnulib updated from 6cc32c to 8d807a
6 changes: 3 additions & 3 deletions bootstrap
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#! /bin/sh
# Print a version string.
scriptversion=2014-12-08.12; # UTC
scriptversion=2016-01-24.06; # UTC

# Bootstrap this package from checked-out sources.

Expand Down Expand Up @@ -42,7 +42,7 @@ export LC_ALL

local_gl_dir=gl

# Honour $PERL, but work even if there is none
# Honor $PERL, but work even if there is none.
PERL="${PERL-perl}"

me=$0
Expand Down Expand Up @@ -1021,6 +1021,6 @@ echo "$0: done. Now you can run './configure'."
# eval: (add-hook 'write-file-hooks 'time-stamp)
# time-stamp-start: "scriptversion="
# time-stamp-format: "%:y-%02m-%02d.%02H"
# time-stamp-time-zone: "UTC"
# time-stamp-time-zone: "UTC0"
# time-stamp-end: "; # UTC"
# End:
9 changes: 3 additions & 6 deletions tests/virstringtest.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (C) 2012-2014 Red Hat, Inc.
* Copyright (C) 2012-2016 Red Hat, Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
Expand All @@ -23,7 +23,6 @@
#include <stdlib.h>

#include "testutils.h"
#include "intprops.h"
#include "verify.h"
#include "virerror.h"
#include "viralloc.h"
Expand Down Expand Up @@ -409,13 +408,11 @@ struct stringToLongData {

/* This test makes assumptions about our compilation platform that are
* not guaranteed by POSIX. Good luck to you if you are crazy enough
* to try and port libvirt to a platform with 16-bit int. */
* to try and port libvirt to a platform with 16-bit int. Gnulib
* already assumes that signed integers are two's complement. */
verify(sizeof(int) == 4);
verify(TYPE_TWOS_COMPLEMENT(int));
verify(sizeof(long) == sizeof(int) || sizeof(long) == sizeof(long long));
verify(TYPE_TWOS_COMPLEMENT(long));
verify(sizeof(long long) == 8);
verify(TYPE_TWOS_COMPLEMENT(long long));

static int
testStringToLong(const void *opaque)
Expand Down

0 comments on commit 0cd6488

Please sign in to comment.