Skip to content

Commit

Permalink
LibWeb: Parse the CSS opacity property with strtof() for now
Browse files Browse the repository at this point in the history
With the new parser, we started interpreting the `opacity` property as a
string value, which made it turn into `auto` and so anything with
opacity ended up not visible (e.g the header on google.com)

This patch restores our old behavior for `opacity` by interpreting it
as a numeric value with optional decimals.
  • Loading branch information
awesomekling committed Aug 20, 2021
1 parent ed7a2f2 commit f58e235
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2869,6 +2869,12 @@ RefPtr<StyleValue> Parser::parse_css_value(ParsingContext const& context, Proper
}
}

// FIXME: This is a hack for the `opacity` property which should really take an <alpha-value>
if (property_id == PropertyID::Opacity && component_value.is(Token::Type::Number)) {
String string = component_value.token().number_string_value();
return LengthStyleValue::create(Length::make_px(strtof(string.characters(), nullptr)));
}

if (auto builtin_or_dynamic = parse_builtin_or_dynamic_value(context, component_value))
return builtin_or_dynamic;

Expand Down

0 comments on commit f58e235

Please sign in to comment.