Kernel: Use a const reference to RegisterState in IRQ handling

cubiclove · Mar 19, 2020 · e880fe0 · e880fe0
1 parent aa43314
commit e880fe0
Show file tree

Hide file tree

Showing 26 changed files with 27 additions and 27 deletions.
diff --git a/Kernel/ACPI/ACPIDynamicParser.cpp b/Kernel/ACPI/ACPIDynamicParser.cpp
@@ -56,7 +56,7 @@ namespace ACPI {
  klog() << "ACPI: Dynamic Parsing Enabled, Can parse AML";
  }
 
- void DynamicParser::handle_irq(RegisterState&)
+ void DynamicParser::handle_irq(const RegisterState&)
  {
  // FIXME: Implement IRQ handling of ACPI signals!
  ASSERT_NOT_REACHED();

diff --git a/Kernel/ACPI/ACPIDynamicParser.h b/Kernel/ACPI/ACPIDynamicParser.h
@@ -56,7 +56,7 @@ namespace ACPI {
  private:
  void build_namespace();
  // ^IRQHandler
- virtual void handle_irq(RegisterState&) override;
+ virtual void handle_irq(const RegisterState&) override;
 
  OwnPtr<Region> m_acpi_namespace;
  };

diff --git a/Kernel/Devices/FloppyDiskDevice.cpp b/Kernel/Devices/FloppyDiskDevice.cpp
@@ -348,7 +348,7 @@ bool FloppyDiskDevice::wait_for_irq()
  return true;
 }
 
-void FloppyDiskDevice::handle_irq(RegisterState&)
+void FloppyDiskDevice::handle_irq(const RegisterState&)
 {
  // The only thing we need to do is acknowledge the IRQ happened
  m_interrupted = true;

diff --git a/Kernel/Devices/FloppyDiskDevice.h b/Kernel/Devices/FloppyDiskDevice.h
@@ -179,7 +179,7 @@ class FloppyDiskDevice final
 
 private:
  // ^IRQHandler
- virtual void handle_irq(RegisterState&) override;
+ virtual void handle_irq(const RegisterState&) override;
 
  // ^DiskDevice
  virtual const char* class_name() const override;

diff --git a/Kernel/Devices/KeyboardDevice.cpp b/Kernel/Devices/KeyboardDevice.cpp
@@ -485,7 +485,7 @@ void KeyboardDevice::key_state_changed(u8 raw, bool pressed)
  m_has_e0_prefix = false;
 }
 
-void KeyboardDevice::handle_irq(RegisterState&)
+void KeyboardDevice::handle_irq(const RegisterState&)
 {
  for (;;) {
  u8 status = IO::in8(I8042_STATUS);

diff --git a/Kernel/Devices/KeyboardDevice.h b/Kernel/Devices/KeyboardDevice.h
@@ -61,7 +61,7 @@ class KeyboardDevice final : public IRQHandler
 
 private:
  // ^IRQHandler
- virtual void handle_irq(RegisterState&) override;
+ virtual void handle_irq(const RegisterState&) override;
 
  // ^CharacterDevice
  virtual const char* class_name() const override { return "KeyboardDevice"; }

diff --git a/Kernel/Devices/PATAChannel.cpp b/Kernel/Devices/PATAChannel.cpp
@@ -180,7 +180,7 @@ void PATAChannel::wait_for_irq()
  disable_irq();
 }
 
-void PATAChannel::handle_irq(RegisterState&)
+void PATAChannel::handle_irq(const RegisterState&)
 {
  u8 status = m_io_base.offset(ATA_REG_STATUS).in<u8>();
  if (status & ATA_SR_ERR) {

diff --git a/Kernel/Devices/PATAChannel.h b/Kernel/Devices/PATAChannel.h
@@ -76,7 +76,7 @@ class PATAChannel final : public PCI::Device {
 
 private:
  //^ IRQHandler
- virtual void handle_irq(RegisterState&) override;
+ virtual void handle_irq(const RegisterState&) override;
 
  void initialize(bool force_pio);
  void detect_disks();

diff --git a/Kernel/Devices/PS2MouseDevice.cpp b/Kernel/Devices/PS2MouseDevice.cpp
@@ -130,7 +130,7 @@ void PS2MouseDevice::handle_vmmouse_absolute_pointer()
  m_queue.enqueue(packet);
 }
 
-void PS2MouseDevice::handle_irq(RegisterState&)
+void PS2MouseDevice::handle_irq(const RegisterState&)
 {
 
  if (VMWareBackdoor::the().vmmouse_is_absolute()) {

diff --git a/Kernel/Devices/PS2MouseDevice.h b/Kernel/Devices/PS2MouseDevice.h
@@ -52,7 +52,7 @@ class PS2MouseDevice final : public IRQHandler
 private:
  // ^IRQHandler
  void handle_vmmouse_absolute_pointer();
- virtual void handle_irq(RegisterState&) override;
+ virtual void handle_irq(const RegisterState&) override;
 
  // ^CharacterDevice
  virtual const char* class_name() const override { return "PS2MouseDevice"; }

diff --git a/Kernel/Devices/SB16.cpp b/Kernel/Devices/SB16.cpp
@@ -207,7 +207,7 @@ void SB16::dma_start(uint32_t length)
  IO::out8(0xd4, (channel % 4));
 }
 
-void SB16::handle_irq(RegisterState&)
+void SB16::handle_irq(const RegisterState&)
 {
  // Stop sound output ready for the next block.
  dsp_write(0xd5);

diff --git a/Kernel/Devices/SB16.h b/Kernel/Devices/SB16.h
@@ -54,7 +54,7 @@ class SB16 final : public IRQHandler
 
 private:
  // ^IRQHandler
- virtual void handle_irq(RegisterState&) override;
+ virtual void handle_irq(const RegisterState&) override;
 
  // ^CharacterDevice
  virtual const char* class_name() const override { return "SB16"; }

diff --git a/Kernel/Interrupts/GenericInterruptHandler.h b/Kernel/Interrupts/GenericInterruptHandler.h
@@ -44,7 +44,7 @@ class GenericInterruptHandler {
 public:
  static GenericInterruptHandler& from(u8 interrupt_number);
  virtual ~GenericInterruptHandler();
- virtual void handle_interrupt(RegisterState& regs) = 0;
+ virtual void handle_interrupt(const RegisterState& regs) = 0;
 
  u8 interrupt_number() const { return m_interrupt_number; }
 

diff --git a/Kernel/Interrupts/IRQHandler.h b/Kernel/Interrupts/IRQHandler.h
@@ -39,8 +39,8 @@ class IRQHandler : public GenericInterruptHandler {
 public:
  virtual ~IRQHandler();
 
- virtual void handle_interrupt(RegisterState& regs) { handle_irq(regs); }
- virtual void handle_irq(RegisterState&) = 0;
+ virtual void handle_interrupt(const RegisterState& regs) { handle_irq(regs); }
+ virtual void handle_irq(const RegisterState&) = 0;
 
  void enable_irq();
  void disable_irq();

diff --git a/Kernel/Interrupts/SharedIRQHandler.cpp b/Kernel/Interrupts/SharedIRQHandler.cpp
@@ -84,7 +84,7 @@ SharedIRQHandler::~SharedIRQHandler()
  disable_interrupt_vector();
 }
 
-void SharedIRQHandler::handle_interrupt(RegisterState& regs)
+void SharedIRQHandler::handle_interrupt(const RegisterState& regs)
 {
  ASSERT_INTERRUPTS_DISABLED();
  increment_invoking_counter();

diff --git a/Kernel/Interrupts/SharedIRQHandler.h b/Kernel/Interrupts/SharedIRQHandler.h
@@ -39,7 +39,7 @@ class SharedIRQHandler final : public GenericInterruptHandler {
 public:
  static void initialize(u8 interrupt_number);
  virtual ~SharedIRQHandler();
- virtual void handle_interrupt(RegisterState& regs) override;
+ virtual void handle_interrupt(const RegisterState& regs) override;
 
  void register_handler(GenericInterruptHandler&);
  void unregister_handler(GenericInterruptHandler&);

diff --git a/Kernel/Interrupts/SpuriousInterruptHandler.cpp b/Kernel/Interrupts/SpuriousInterruptHandler.cpp
@@ -59,7 +59,7 @@ SpuriousInterruptHandler::~SpuriousInterruptHandler()
 {
 }
 
-void SpuriousInterruptHandler::handle_interrupt(RegisterState&)
+void SpuriousInterruptHandler::handle_interrupt(const RegisterState&)
 {
  // FIXME: Actually check if IRQ7 or IRQ15 are spurious, and if not, call the real handler to handle the IRQ.
  klog() << "Spurious Interrupt, vector " << interrupt_number();

diff --git a/Kernel/Interrupts/SpuriousInterruptHandler.h b/Kernel/Interrupts/SpuriousInterruptHandler.h
@@ -39,7 +39,7 @@ class SpuriousInterruptHandler final : public GenericInterruptHandler {
 public:
  static void initialize(u8 interrupt_number);
  virtual ~SpuriousInterruptHandler();
- virtual void handle_interrupt(RegisterState& regs) override;
+ virtual void handle_interrupt(const RegisterState& regs) override;
 
  void register_handler(GenericInterruptHandler&);
  void unregister_handler(GenericInterruptHandler&);

diff --git a/Kernel/Interrupts/UnhandledInterruptHandler.cpp b/Kernel/Interrupts/UnhandledInterruptHandler.cpp
@@ -32,7 +32,7 @@ UnhandledInterruptHandler::UnhandledInterruptHandler(u8 interrupt_vector)
 {
 }
 
-void UnhandledInterruptHandler::handle_interrupt(RegisterState&)
+void UnhandledInterruptHandler::handle_interrupt(const RegisterState&)
 {
  dbg() << "Interrupt: Unhandled vector " << interrupt_number() << " was invoked for handle_interrupt(RegisterState&).";
  hang();

diff --git a/Kernel/Interrupts/UnhandledInterruptHandler.h b/Kernel/Interrupts/UnhandledInterruptHandler.h
@@ -37,7 +37,7 @@ class UnhandledInterruptHandler final : public GenericInterruptHandler {
  explicit UnhandledInterruptHandler(u8 interrupt_vector);
  virtual ~UnhandledInterruptHandler();
 
- virtual void handle_interrupt(RegisterState&) override;
+ virtual void handle_interrupt(const RegisterState&) override;
 
  virtual bool eoi() override;
 

diff --git a/Kernel/Net/E1000NetworkAdapter.cpp b/Kernel/Net/E1000NetworkAdapter.cpp
@@ -177,7 +177,7 @@ E1000NetworkAdapter::~E1000NetworkAdapter()
 {
 }
 
-void E1000NetworkAdapter::handle_irq(RegisterState&)
+void E1000NetworkAdapter::handle_irq(const RegisterState&)
 {
  out32(REG_IMASK, 0x1);
 

diff --git a/Kernel/Net/E1000NetworkAdapter.h b/Kernel/Net/E1000NetworkAdapter.h
@@ -49,7 +49,7 @@ class E1000NetworkAdapter final : public NetworkAdapter
  virtual const char* purpose() const override { return class_name(); }
 
 private:
- virtual void handle_irq(RegisterState&) override;
+ virtual void handle_irq(const RegisterState&) override;
  virtual const char* class_name() const override { return "E1000NetworkAdapter"; }
 
  struct [[gnu::packed]] e1000_rx_desc

diff --git a/Kernel/Net/RTL8139NetworkAdapter.cpp b/Kernel/Net/RTL8139NetworkAdapter.cpp
@@ -177,7 +177,7 @@ RTL8139NetworkAdapter::~RTL8139NetworkAdapter()
 {
 }
 
-void RTL8139NetworkAdapter::handle_irq(RegisterState&)
+void RTL8139NetworkAdapter::handle_irq(const RegisterState&)
 {
  for (;;) {
  int status = in16(REG_ISR);

diff --git a/Kernel/Net/RTL8139NetworkAdapter.h b/Kernel/Net/RTL8139NetworkAdapter.h
@@ -50,7 +50,7 @@ class RTL8139NetworkAdapter final : public NetworkAdapter
  virtual const char* purpose() const override { return class_name(); }
 
 private:
- virtual void handle_irq(RegisterState&) override;
+ virtual void handle_irq(const RegisterState&) override;
  virtual const char* class_name() const override { return "RTL8139NetworkAdapter"; }
 
  void reset();

diff --git a/Kernel/Scheduler.cpp b/Kernel/Scheduler.cpp
@@ -580,7 +580,7 @@ void Scheduler::initialize()
  load_task_register(s_redirection.selector);
 }
 
-void Scheduler::timer_tick(RegisterState& regs)
+void Scheduler::timer_tick(const RegisterState& regs)
 {
  if (!Thread::current)
  return;

diff --git a/Kernel/Scheduler.h b/Kernel/Scheduler.h
@@ -49,7 +49,7 @@ extern SchedulerData* g_scheduler_data;
 class Scheduler {
 public:
  static void initialize();
- static void timer_tick(RegisterState&);
+ static void timer_tick(const RegisterState&);
  static bool pick_next();
  static void pick_next_and_switch_now();
  static void switch_now();