Skip to content

Commit

Permalink
LibJS: Implement Temporal.Duration.prototype.nanoseconds
Browse files Browse the repository at this point in the history
  • Loading branch information
linusg committed Jul 16, 2021
1 parent 04e2d21 commit be5254d
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 0 deletions.
1 change: 1 addition & 0 deletions Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ namespace JS {
P(months) \
P(multiline) \
P(name) \
P(nanoseconds) \
P(next) \
P(now) \
P(of) \
Expand Down
14 changes: 14 additions & 0 deletions Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ void DurationPrototype::initialize(GlobalObject& global_object)
define_native_accessor(vm.names.seconds, seconds_getter, {}, Attribute::Configurable);
define_native_accessor(vm.names.milliseconds, milliseconds_getter, {}, Attribute::Configurable);
define_native_accessor(vm.names.microseconds, microseconds_getter, {}, Attribute::Configurable);
define_native_accessor(vm.names.nanoseconds, nanoseconds_getter, {}, Attribute::Configurable);
}

static Duration* typed_this(GlobalObject& global_object)
Expand Down Expand Up @@ -166,4 +167,17 @@ JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::microseconds_getter)
return Value(duration->microseconds());
}

// 7.3.12 get Temporal.Duration.prototype.nanoseconds, https://tc39.es/proposal-temporal/#sec-get-temporal.duration.prototype.nanoseconds
JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::nanoseconds_getter)
{
// 1. Let duration be the this value.
// 2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]).
auto* duration = typed_this(global_object);
if (vm.exception())
return {};

// 3. Return duration.[[Nanoseconds]].
return Value(duration->nanoseconds());
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ class DurationPrototype final : public Object {
JS_DECLARE_NATIVE_FUNCTION(seconds_getter);
JS_DECLARE_NATIVE_FUNCTION(milliseconds_getter);
JS_DECLARE_NATIVE_FUNCTION(microseconds_getter);
JS_DECLARE_NATIVE_FUNCTION(nanoseconds_getter);
};

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
describe("correct behavior", () => {
test("basic functionality", () => {
const duration = new Temporal.Duration(0, 0, 0, 0, 0, 0, 0, 0, 0, 123);
expect(duration.nanoseconds).toBe(123);
});
});

test("errors", () => {
test("this value must be a Temporal.Duration object", () => {
expect(() => {
Reflect.get(Temporal.Duration.prototype, "nanoseconds", "foo");
}).toThrowWithMessage(TypeError, "Not a Temporal.Duration");
});
});

0 comments on commit be5254d

Please sign in to comment.