Skip to content

Commit

Permalink
TextEditor: Let's have line numbers starting at 1.
Browse files Browse the repository at this point in the history
Thanks to Dan for pointing this out on IRC:

<danboid> I see TextEditor still numbers its lines from 0. You're too much of a programmer sometimes kling! :)
<  kling> that might be the most extreme form of "programmer design" I've seen in serenity
  • Loading branch information
awesomekling committed Jul 27, 2019
1 parent 6a03196 commit b98c772
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Applications/TextEditor/TextEditorWidget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ TextEditorWidget::TextEditorWidget()

m_editor->on_cursor_change = [statusbar, this] {
StringBuilder builder;
builder.appendf("Line: %d, Column: %d", m_editor->cursor().line(), m_editor->cursor().column());
builder.appendf("Line: %d, Column: %d", m_editor->cursor().line() + 1, m_editor->cursor().column());
statusbar->set_text(builder.to_string());
};

Expand Down
2 changes: 1 addition & 1 deletion Libraries/LibGUI/GTextEditor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ void GTextEditor::paint_event(GPaintEvent& event)
auto ruler_line_rect = ruler_content_rect(i);
painter.draw_text(
ruler_line_rect.shrunken(2, 0),
String::number(i),
String::number(i + 1),
is_current_line ? Font::default_bold_font() : font(),
TextAlignment::CenterRight,
is_current_line ? Color::DarkGray : Color::MidGray);
Expand Down

0 comments on commit b98c772

Please sign in to comment.