Skip to content

Commit

Permalink
PixelPaint: Add Crop to Selection Action
Browse files Browse the repository at this point in the history
In addition to adding the action, this commit also makes the
`did_change_rect()` method take in an optional rect, which
represents the new rect position. By default it is the same as
`rect()`.

When we are cropping an image, we don't want to move the whole
cropped section to the top-left of the original image in the
ImageEditor widget, so this allows us to keep the cropped image's
position fixed.
  • Loading branch information
mustafaquraish authored and awesomekling committed Sep 6, 2021
1 parent 456938a commit 905bc79
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 3 deletions.
18 changes: 16 additions & 2 deletions Userland/Applications/PixelPaint/Image.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -458,10 +458,11 @@ void Image::did_change(Gfx::IntRect const& a_modified_rect)
client->image_did_change(modified_rect);
}

void Image::did_change_rect()
void Image::did_change_rect(Gfx::IntRect const& a_modified_rect)
{
auto modified_rect = a_modified_rect.is_empty() ? this->rect() : a_modified_rect;
for (auto* client : m_clients)
client->image_did_change_rect(rect());
client->image_did_change_rect(modified_rect);
}

ImageUndoCommand::ImageUndoCommand(Image& image)
Expand Down Expand Up @@ -518,4 +519,17 @@ void Image::rotate(Gfx::RotationDirection direction)
did_change_rect();
}

void Image::crop(Gfx::IntRect const& cropped_rect)
{
for (auto& layer : m_layers) {
auto cropped = layer.bitmap().cropped(cropped_rect);
VERIFY(cropped);
layer.set_bitmap(*cropped);
layer.did_modify_bitmap(rect());
}

m_size = { cropped_rect.width(), cropped_rect.height() };
did_change_rect(cropped_rect);
}

}
3 changes: 2 additions & 1 deletion Userland/Applications/PixelPaint/Image.h
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,13 @@ class Image : public RefCounted<Image> {

void flip(Gfx::Orientation orientation);
void rotate(Gfx::RotationDirection direction);
void crop(Gfx::IntRect const& rect);

private:
explicit Image(Gfx::IntSize const&);

void did_change(Gfx::IntRect const& modified_rect = {});
void did_change_rect();
void did_change_rect(Gfx::IntRect const& modified_rect = {});
void did_modify_layer_stack();

String m_path;
Expand Down
11 changes: 11 additions & 0 deletions Userland/Applications/PixelPaint/MainWidget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,17 @@ void MainWidget::initialize_menubar(GUI::Window& window)
return;
editor->image().rotate(Gfx::RotationDirection::Clockwise);
}));
image_menu.add_separator();
image_menu.add_action(GUI::Action::create(
"&Crop To Selection", [&](auto&) {
auto* editor = current_image_editor();
// FIXME: disable this action if there is no selection
if (!editor || editor->selection().is_empty())
return;
auto crop_rect = editor->selection().bounding_rect();
editor->image().crop(crop_rect);
editor->selection().clear();
}));

auto& layer_menu = window.add_menu("&Layer");
layer_menu.add_action(GUI::Action::create(
Expand Down

0 comments on commit 905bc79

Please sign in to comment.