LibJS: Implement Temporal.Duration.prototype.valueOf()

cubiclove · Jul 16, 2021 · 8daf35e · 8daf35e
1 parent a06b034
commit 8daf35e
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp
@@ -37,6 +37,9 @@ void DurationPrototype::initialize(GlobalObject& global_object)
  define_native_accessor(vm.names.nanoseconds, nanoseconds_getter, {}, Attribute::Configurable);
  define_native_accessor(vm.names.sign, sign_getter, {}, Attribute::Configurable);
  define_native_accessor(vm.names.blank, blank_getter, {}, Attribute::Configurable);
+
+ u8 attr = Attribute::Writable | Attribute::Configurable;
+ define_native_function(vm.names.valueOf, value_of, 0, attr);
 }
 
 static Duration* typed_this(GlobalObject& global_object)
@@ -215,4 +218,12 @@ JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::blank_getter)
  return Value(false);
 }
 
+// 7.3.25 Temporal.Duration.prototype.valueOf ( ), https://tc39.es/proposal-temporal/#sec-temporal.duration.prototype.valueof
+JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::value_of)
+{
+ // 1. Throw a TypeError exception.
+ vm.throw_exception<TypeError>(global_object, ErrorType::Convert, "Temporal.Duration", "a primitive value");
+ return {};
+}
+
 }
diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h b/Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.h
@@ -31,6 +31,7 @@ class DurationPrototype final : public Object {
  JS_DECLARE_NATIVE_FUNCTION(nanoseconds_getter);
  JS_DECLARE_NATIVE_FUNCTION(sign_getter);
  JS_DECLARE_NATIVE_FUNCTION(blank_getter);
+ JS_DECLARE_NATIVE_FUNCTION(value_of);
 };
 
 }
diff --git a/Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.valueOf.js b/Userland/Libraries/LibJS/Tests/builtins/Temporal/Duration/Duration.prototype.valueOf.js
@@ -0,0 +1,7 @@
+test("errors", () => {
+ test("throws TypeError", () => {
+ expect(() => {
+ new Temporal.Duration().valueOf();
+ }).toThrowWithMessage(TypeError, "Cannot convert Temporal.Duration to a primitive value");
+ });
+});