Skip to content

Commit

Permalink
Revert "LibWeb: Add stub for IDBFactory.open"
Browse files Browse the repository at this point in the history
This reverts commit f7beea1.

This broke loading https://x.com/
  • Loading branch information
awesomekling committed May 22, 2024
1 parent c83fc59 commit 79870bc
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 16 deletions.
9 changes: 0 additions & 9 deletions Userland/Libraries/LibWeb/IndexedDB/IDBFactory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#include <LibWeb/Bindings/IDBFactoryPrototype.h>
#include <LibWeb/Bindings/Intrinsics.h>
#include <LibWeb/IndexedDB/IDBFactory.h>
#include <LibWeb/IndexedDB/IDBOpenDBRequest.h>

namespace Web::IndexedDB {

Expand All @@ -26,12 +25,4 @@ void IDBFactory::initialize(JS::Realm& realm)
WEB_SET_PROTOTYPE_FOR_INTERFACE(IDBFactory);
}

// https://w3c.github.io/IndexedDB/#dom-idbfactory-open
JS::NonnullGCPtr<IDBOpenDBRequest> IDBFactory::open(String const&, Optional<WebIDL::UnsignedLongLong>)
{
dbgln("FIXME: Implement IDBFactory::open");
auto& realm = this->realm();
return vm().heap().allocate<IDBOpenDBRequest>(realm, realm);
}

}
3 changes: 0 additions & 3 deletions Userland/Libraries/LibWeb/IndexedDB/IDBFactory.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
#pragma once

#include <LibWeb/Bindings/PlatformObject.h>
#include <LibWeb/WebIDL/Types.h>

namespace Web::IndexedDB {

Expand All @@ -19,8 +18,6 @@ class IDBFactory : public Bindings::PlatformObject {
public:
virtual ~IDBFactory() override;

JS::NonnullGCPtr<IDBOpenDBRequest> open(String const& name, Optional<WebIDL::UnsignedLongLong> version = {});

protected:
explicit IDBFactory(JS::Realm&);

Expand Down
6 changes: 2 additions & 4 deletions Userland/Libraries/LibWeb/IndexedDB/IDBFactory.idl
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
#import <IndexedDB/IDBOpenDBRequest.idl>

// https://w3c.github.io/IndexedDB/#idbfactory
[Exposed=(Window,Worker)]
interface IDBFactory {
[NewObject] IDBOpenDBRequest open(DOMString name,
optional [EnforceRange] unsigned long long version);
// FIXME: [NewObject] IDBOpenDBRequest open(DOMString name,
// optional [EnforceRange] unsigned long long version);
[FIXME, NewObject] IDBOpenDBRequest deleteDatabase(DOMString name);

[FIXME] Promise<sequence<IDBDatabaseInfo>> databases();
Expand Down

0 comments on commit 79870bc

Please sign in to comment.