Skip to content

Commit

Permalink
WebContent: Pass the script timeout into the WebDriver script executor
Browse files Browse the repository at this point in the history
This was dropped in 0b9803d and 31469ee before the timeouts object was
avaiable in WebContent.
  • Loading branch information
trflynn89 authored and linusg committed Nov 11, 2022
1 parent 04f41bd commit 6a55370
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions Userland/Services/WebContent/WebDriverConnection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -900,8 +900,7 @@ Messages::WebDriverClient::ExecuteScriptResponse WebDriverConnection::execute_sc
// FIXME: 3. Handle any user prompts, and return its value if it is an error.

// 4., 5.1-5.3.
// FIXME: Move timeouts from WebDriver to WebContent and pass the script timeout through here.
auto result = Web::WebDriver::execute_script(m_page_host.page(), body, move(arguments), {});
auto result = Web::WebDriver::execute_script(m_page_host.page(), body, move(arguments), m_timeouts_configuration.script_timeout);
dbgln_if(WEBDRIVER_DEBUG, "Executing script returned: {}", result.value);

switch (result.type) {
Expand Down Expand Up @@ -932,8 +931,7 @@ Messages::WebDriverClient::ExecuteAsyncScriptResponse WebDriverConnection::execu
// FIXME: 3. Handle any user prompts, and return its value if it is an error.

// 4., 5.1-5.11.
// FIXME: Move timeouts from WebDriver to WebContent and pass the script timeout through here.
auto result = Web::WebDriver::execute_async_script(m_page_host.page(), body, move(arguments), {});
auto result = Web::WebDriver::execute_async_script(m_page_host.page(), body, move(arguments), m_timeouts_configuration.script_timeout);
dbgln_if(WEBDRIVER_DEBUG, "Executing async script returned: {}", result.value);

switch (result.type) {
Expand Down

0 comments on commit 6a55370

Please sign in to comment.