TTY: Properly implement echo in VirtualConsole.

VirtualConsole::echo now actually echoes characters instead of doing nothing.
cubiclove · Oct 30, 2019 · 378480e · 378480e
1 parent ed45f67
commit 378480e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/Kernel/TTY/VirtualConsole.cpp b/Kernel/TTY/VirtualConsole.cpp
@@ -545,6 +545,13 @@ StringView VirtualConsole::tty_name() const
  return m_tty_name;
 }
 
+void VirtualConsole::echo(u8 ch)
+{
+ if (should_echo_input()) {
+ on_tty_write(&ch, 1);
+ }
+}
+
 void VirtualConsole::set_vga_start_row(u16 row)
 {
  m_vga_start_row = row;

diff --git a/Kernel/TTY/VirtualConsole.h b/Kernel/TTY/VirtualConsole.h
@@ -33,7 +33,7 @@ class VirtualConsole final : public TTY
  // ^TTY
  virtual ssize_t on_tty_write(const u8*, ssize_t) override;
  virtual StringView tty_name() const override;
- virtual void echo(u8) override { return; }
+ virtual void echo(u8) override;
 
  // ^CharacterDevice
  virtual const char* class_name() const override { return "VirtualConsole"; }