Skip to content

Commit

Permalink
Kernel: Call try_set_coredump_property with StringView arguments
Browse files Browse the repository at this point in the history
Storing assigning a string literal to a String object just to pass it to
a function expecting a StringView is wasteful. Let's just not do that.

For consistency's sake, this commit changes all of the other invocations
to use StringView literals, too.
  • Loading branch information
BertalanD authored and awesomekling committed Oct 21, 2021
1 parent bbb4eb0 commit 17b66ea
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions Kernel/Arch/x86/common/Interrupts.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -403,14 +403,14 @@ void page_fault_handler(TrapFrame* trap)
if (current_thread) {
auto& current_process = current_thread->process();
if (current_process.is_user_process()) {
(void)current_process.try_set_coredump_property("fault_address", String::formatted("{:p}", fault_address));
(void)current_process.try_set_coredump_property("fault_type", fault.type() == PageFault::Type::PageNotPresent ? "NotPresent" : "ProtectionViolation");
String fault_access;
(void)current_process.try_set_coredump_property("fault_address"sv, String::formatted("{:p}", fault_address));
(void)current_process.try_set_coredump_property("fault_type"sv, fault.type() == PageFault::Type::PageNotPresent ? "NotPresent"sv : "ProtectionViolation"sv);
StringView fault_access;
if (fault.is_instruction_fetch())
fault_access = "Execute";
fault_access = "Execute"sv;
else
fault_access = fault.access() == PageFault::Access::Read ? "Read" : "Write";
(void)current_process.try_set_coredump_property("fault_access", fault_access);
fault_access = fault.access() == PageFault::Access::Read ? "Read"sv : "Write"sv;
(void)current_process.try_set_coredump_property("fault_access"sv, fault_access);
}
}

Expand Down

0 comments on commit 17b66ea

Please sign in to comment.