Preserve banner names across place and pick up #5565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Jagdis <[email protected]>
bearbin
reviewed
Jun 30, 2024
src/BlockEntities/BannerEntity.h
Outdated
| @@ -25,16 +25,20 @@ class cBannerEntity : | |||
|
|
|||
| public: | |||
|
|
|||
| cBannerEntity(BLOCKTYPE a_BlockType, NIBBLETYPE a_BlockMeta, Vector3i a_Pos, cWorld * a_World); | |||
| cBannerEntity(BLOCKTYPE a_BlockType, NIBBLETYPE a_BlockMeta, Vector3i a_Pos, cWorld * a_World, unsigned char a_BaseColor); | |||
| cBannerEntity(BLOCKTYPE a_BlockType, NIBBLETYPE a_BlockMeta, Vector3i a_Pos, cWorld * a_World, unsigned char a_BaseColor = 15, AString a_CustomName = ""); | |||
There was a problem hiding this comment.
Previously the default BaseColor was 1, now it's 15?
There was a problem hiding this comment.
It's a bit pedantic, I guess :-). Banner colours are inverted 0-15 so 15 is white (0 is black and 1 is just somewhat random). That said crafting a banner always sets damage (i.e. colour) on the crafted item, loading by WSSAnvil always sets the colour to whatever was saved and placing a banner always does a SetBaseColor using the source item's damage. Unless there's a way to magic a banner into existence from Lua (I haven't checked) those two defaulted args have no real purpose and could be vacuumed up?
bearbin
reviewed
Jun 30, 2024
bearbin
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with named enchanting tables, copy banner names back and forth between items and block entities. NBT format verified against actual Java Edition chunk saves.
Fixes #5564