Enchant changes #117
Merged
Enchant changes #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to vanilla The code was there, but it appears it was forgotten when changing over to the Info.lua command registration format and was thus inactive. Also changed command to behave more like vanilla (adding player name option, disallowing certain parameter combinations, etc.). Added /ienchant command to maintain behavior of previous command without player name option.
| SendMessageFailure(Player, "You haven't a item in the hand!") | ||
|
|
||
| -- Try to enchant the item | ||
| local Success = cRoot:Get():FindAndDoWithPlayer( PlayerName, DoEnchantment ) |
There was a problem hiding this comment.
To avoid having to check the player name match, use the DoWithPlayer() function instead - it only calls the callback on an exact match
There was a problem hiding this comment.
Is that function exported to lua? Its not listed on the generated API docs for the cRoot class. Also, does that function ignore case like FindAndDoWithPlayer() does? The one exported in cWorld seems to imply that its case sensitive.
There was a problem hiding this comment.
You're right, it doesn't seem to have been exported yet. Alright, I'll merge this as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reenables
enchantcommand that had been previously disabled during the switch to Info.lua command registering. Updates the enchant command to behave more like vanilla minecraft, and adds theienchantcommand to allow only enchanting ones own items (similar to the difference betweengiveanditemcommands ).