Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOTD doesn't display due to hook conflict #235

Closed
tigerw opened this issue Jan 11, 2021 · 0 comments · Fixed by #236
Closed

MOTD doesn't display due to hook conflict #235

tigerw opened this issue Jan 11, 2021 · 0 comments · Fixed by #236

Comments

@tigerw
Copy link
Member

tigerw commented Jan 11, 2021

Function OnPlayerJoined exists in both core_motd.lua and web_chat.lua and is not tagged local in either. This means the message of the day is no longer printed. I suggest local hooks akin to whitelist/banlist.lua
tigerw added a commit that referenced this issue Mar 6, 2021
@tigerw
Fix MOTD display
96419d2 
* Fixes #235
@tigerw tigerw mentioned this issue Mar 6, 2021
Merged
mathiascode pushed a commit that referenced this issue Mar 6, 2021
@tigerw
Fix MOTD display (#236)
891c574 
* Fixes #235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix MOTD display cuberite/Core
1 participant
@tigerw