Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/plugins command is broken #133

Closed
mathiascode opened this issue Apr 26, 2015 · 5 comments · Fixed by #134
Closed

/plugins command is broken #133

mathiascode opened this issue Apr 26, 2015 · 5 comments · Fixed by #134
Assignees

Comments

@mathiascode
Copy link
Member

After updating MCServer to the latest version, the /plugins command has stopped working.

This error appears in the console:

[13:59:03] Stack trace:
[13:59:03]   [C](-1): GetAllPlugins
[13:59:03]   Plugins/Core/plugins.lua(3): (no name)
[13:59:03] Stack trace end
[13:59:04] PluginManager:GetAllPlugins() is no longer available, use cPluginManager:ForEachPlugin() instead
@madmaxoft
Copy link
Member

Are you using the latest Core version? It has been updated after the API change.

@mathiascode
Copy link
Member Author

Yes, Core was updated at the same time. I updated about an hour ago. I can confirm it was updated, as a change I had done to Core reset after the update.

I looked at the source code here on GitHub, and it seems like PluginManager:GetAllPlugins() still is used in plugins.lua. The file was last updated on Jul 27, 2014.

@NiLSPACE
Copy link
Member

You forgot to update the in-game command: https://github.com/mc-server/Core/blob/master/plugins.lua#L3

@madmaxoft
Copy link
Member

Ah, I had no idea we had an in-game command, too. I fixed only the console command.

@madmaxoft madmaxoft self-assigned this Apr 26, 2015
madmaxoft added a commit that referenced this issue Apr 26, 2015
It now uses the correct API and additionally filters the output on plugin status.
Fixes #133.
@madmaxoft
Copy link
Member

There, a fix and an enhancement. Now you can filter the output by plugin status (loaded, unloaded, error, disabled, notfound, all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants