Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semicolon and other style conventions. #11

Closed
bearbin opened this issue Aug 6, 2013 · 4 comments
Closed

Semicolon and other style conventions. #11

bearbin opened this issue Aug 6, 2013 · 4 comments
Labels
question

Comments

@bearbin
Copy link
Member

bearbin commented Aug 6, 2013

I assume that this repo should be using tabs for indentation and spaces for alignment, and unix line endings. Should we be using semicolons at the end of lines (they're optional) as they seem to have mixed use in the repo. Also, if there are any other lua conventions that must be followed, please tell me 😄
@tigerw
Copy link
Member

tigerw commented Aug 7, 2013

Remove all der semicolons!

@madmaxoft
Copy link
Member

I'd have preferred to keep the semicolons, because I put them in automatically, being used to them from C++.
Also consider keeping parenthesis around boolean expressions, such as (a == b). They're not compulsory, but they make the code quite a bit more readable, especially in compound expressions, such as (a == b) or (c == d)

@tigerw
Copy link
Member

tigerw commented Sep 24, 2013

Just confirming for anyone who is reading this that convention for all new code is tabs for indentation and spaces for alignment. Also, no semicolons for plugins.

@tigerw tigerw closed this as completed Sep 24, 2013
@bearbin bearbin mentioned this issue Aug 21, 2017
Closed
@madmaxoft
Copy link
Member

I'm eating my own words from four years ago. There's no need for semicolons in Lua, so let's let them go :)

mathiascode added a commit that referenced this issue May 10, 2020
@mathiascode
# This is a combination of 24 commits.
866ddd6 
# This is the 1st commit message:

Create ci.yml
# This is the commit message #2:

Update URLs
# This is the commit message #3:

Delete circle.yml
# This is the commit message #4:

Use lua
# This is the commit message #5:

luafilesystem
# This is the commit message #6:

Use luarocks
# This is the commit message #7:

Install sqlite
# This is the commit message #8:

Use sudo for luarocks
# This is the commit message #9:

Update ci.yml
# This is the commit message #10:

Specify plugin
# This is the commit message #11:

lsqlite3
# This is the commit message #12:

libsqlite3-dev
# This is the commit message #13:

Update ci.yml
# This is the commit message #14:

Remove fishing float
# This is the commit message #15:

Update ci.yml
# This is the commit message #16:

Update ci.yml
# This is the commit message #17:

Update ci.yml
# This is the commit message #18:

Update ci.yml
# This is the commit message #19:

Update ci.yml
# This is the commit message #20:

Update ci.yml
# This is the commit message #21:

Update ci.yml
# This is the commit message #22:

test
# This is the commit message #23:

test2
# This is the commit message #24:

test3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bearbin @tigerw @madmaxoft