55 html groovy template #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreysubbotin
requested changes
Nov 14, 2018
| * @return if it is groovy html template. | ||
| */ | ||
| boolean isGroovy(); | ||
|
|
There was a problem hiding this comment.
Set method default, for backforward compatibility with Reporting. By default returns false
| htmlTemplate.make(templateModel).writeTo(htmlWriter); | ||
| htmlWriter.close(); | ||
| } catch (Exception e) { | ||
| throw wrapWithReportingException("Unable to write Groovy template content", e); |
There was a problem hiding this comment.
Change exception message to: "An error occurred while rendering html document." - same as for FreeMarker template
There was a problem hiding this comment.
And add processing reporting exception: not to wrap exception again. It same as for FreemarkerTemplate
| throw e; | ||
| } catch (Exception e) { | ||
| throw wrapWithReportingException("An error occurred while rendering html document.", e); | ||
| if (Boolean.TRUE.equals(reportTemplate.isGroovy())){ |
There was a problem hiding this comment.
reportTemplate.isGroovy returns value type boolean, not object type Boolean, so you can check without Boolean.TRUE
andreysubbotin
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.