Support RTL languages print from HTML to PDF. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi, Could you please sign CLA and match adiatullin user with the Github user? |
andreysubbotin
requested changes
Mar 21, 2018
| import java.io.IOException; | ||
| import java.io.OutputStream; | ||
|
|
||
| public interface PdfConverter { |
There was a problem hiding this comment.
Rename to 'HtmlToPdfConverter'
| protected PdfConverter createPdfConverter() { | ||
| return openHtmlForPdfConversion ? new OpenHtmlToPdfConverter() : new ITextPdfConverter(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Introduce new factory: HtmlToPdfConverterFactory
Set HtmlToPdfConverterFactory for HTML formatter in the DefaultFormatterFactory.
| protected void loadFontsFromDirectory(ITextRenderer renderer, File fontsDir) { | ||
| loadFontsFromDirectory(new ITextPdfConverter(renderer), fontsDir); | ||
| } | ||
|
|
||
| protected void loadFonts(HtmlToPdfConverter converter) { |
There was a problem hiding this comment.
Please, do not remove deprecated methods. Methods are used for backward compatibility.
andreysubbotin
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated new pdf rendering library 'Openhtmltopdf' which correct prints RTL languages.