fix of two vertical bands overlaying #18
Conversation
|
tried this fix and it does not fix our issue (1 vertical band that extends to overlap a previous horizontal band). LibreOffice opens the file correctly, M$Excel gives warning about errors, then when asked to fix them the whole place that was supposed to be populated by the vertical band is empty. If the horizontal band is defined (and populated) after the vertical band expansion, then M$Excel works correctly. |
| @@ -591,6 +602,17 @@ protected Row findNextRowForVBand(BandData band, Range templateRange, List<Row> | |||
| return firstRow; | |||
| } | |||
|
|
|||
| protected boolean isNotRenderedYet(List<BandData> bandDataList) { | |||
| if(CollectionUtils.isNotEmpty(bandDataList)) { | |||
| for (BandData bandData : bandDataList) { | |||
There was a problem hiding this comment.
Can we use stream.containsAny here?
| @@ -573,7 +573,18 @@ protected Row findNextRowForHBand(BandData band, Range templateRange, List<Row> | |||
| protected Row findNextRowForVBand(BandData band, Range templateRange, List<Row> resultSheetRows) { | |||
| Row firstRow = null; | |||
| boolean isFirstLevelBand = BandData.ROOT_BAND_NAME.equals(band.getParentBand().getName()); | |||
| previousRangesRightOffset = 0; | |||
| //if this band is first rendered band of all its siblings | |||
| if (isNotRenderedYet(band.getParentBand().getChildrenList())) { | |||
There was a problem hiding this comment.
You can get NPE here because you check it later.
|
is this issue fixed ? |
…s defined as Sheet1!$1:$4) #18
|
Rushan Zagidullin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sample. This solution works for my situation discribed in CUBA forum This solution is not fully tested