Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed converting alt chunks #148

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Conversation

Desire456
Copy link
Contributor

No description provided.

@Desire456 Desire456 requested a review from gorbunkov July 1, 2021 10:24
Copy link
Contributor

@gorbunkov gorbunkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please briefly explain the changes?

@Desire456
Copy link
Contributor Author

The way to provide HTML content into Docx document: we add altChunk into P (paragraph) (in this case altChunk and R (run) are siblings) and then before saving the document convert these altChunks and add altChunk content into P. The second part of this approach is not ideal. If we have HTML content containing P and add content from P to other P, we lost the RPR (paragraph runtime properties) (settings of indentations, tabs, etc). I suggest we should add the HTML content into P parent content (P containing R with altChunk) - now content parts from altChunk andP are siblings.

@gorbunkov gorbunkov self-requested a review July 7, 2021 12:42
@Desire456 Desire456 merged commit ed8850c into master Jul 8, 2021
@Desire456 Desire456 deleted the 145-wrong-html-content-displaying branch July 8, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants