Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: do not ask for file extension if template has alterable o… #103

Closed
wants to merge 1 commit into from
Closed

Suggestion: do not ask for file extension if template has alterable o… #103

wants to merge 1 commit into from

Conversation

NikitaShchienko
Copy link
Contributor

…utput #37

@NikitaShchienko NikitaShchienko self-assigned this Feb 20, 2019
andreysubbotin
andreysubbotin requested changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@andreysubbotin andreysubbotin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failed after fix :

ReportingTest > testReporting FAILED
    junit.framework.ComparisonFailure at ReportingTest.java:63
ReportingTest > testReportWithDefaultParameters FAILED
    junit.framework.ComparisonFailure at ReportingTest.java:98

@andreysubbotin andreysubbotin deleted the Feature/file-extension-output-name-pattern branch March 1, 2019 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreysubbotin andreysubbotin andreysubbotin requested changes

Assignees

@NikitaShchienko NikitaShchienko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NikitaShchienko @andreysubbotin