Skip to content

Commit

Permalink
Fix tests sql varchar with undefined length
Browse files Browse the repository at this point in the history
  • Loading branch information
jreznot committed Nov 16, 2016
1 parent 81a8cc5 commit 9326fc0
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions core/modules/core/test/sample/bookstore/BookStoreTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ public void testBookStoreReport() throws Exception {
//ignore
}

connection.createStatement().executeUpdate("create table store (id integer, name varchar, address varchar);");
connection.createStatement().executeUpdate("create table book(id integer, name varchar, author varchar, price decimal, store_id integer);");
connection.createStatement().executeUpdate("create table store (id integer, name varchar(200), address varchar(200));");
connection.createStatement().executeUpdate("create table book(id integer, name varchar(200), author varchar(200), price decimal, store_id integer);");

connection.createStatement().executeUpdate("insert into store values(1, 'Main store', 'Some street');");
connection.createStatement().executeUpdate("insert into store values(2, 'Secondary store', 'Another street');");
Expand Down
4 changes: 2 additions & 2 deletions core/modules/core/test/sample/bookstore2/BookStore2Test.java
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ public void testBookStoreReport() throws Exception {
//ignore
}

connection.createStatement().executeUpdate("create table store (id integer, name varchar, address varchar);");
connection.createStatement().executeUpdate("create table book(id integer, name varchar, author varchar, price decimal, store_id integer);");
connection.createStatement().executeUpdate("create table store (id integer, name varchar(200), address varchar(200));");
connection.createStatement().executeUpdate("create table book(id integer, name varchar(200), author varchar(200), price decimal, store_id integer);");

connection.createStatement().executeUpdate("insert into store values(1, 'Main store', 'Some street');");
connection.createStatement().executeUpdate("insert into store values(2, 'Secondary store', 'Another street');");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ public void testBreakdownReport() throws Exception {
//ignore
}

connection.createStatement().executeUpdate("create table month_batch (month varchar);");
connection.createStatement().executeUpdate("create table sold_item (month varchar, name varchar, price decimal);");
connection.createStatement().executeUpdate("create table month_batch (month varchar(10));");
connection.createStatement().executeUpdate("create table sold_item (month varchar(10), name varchar(100), price decimal);");

connection.createStatement().executeUpdate("insert into month_batch values('Jan');");
connection.createStatement().executeUpdate("insert into month_batch values('Feb');");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public void init() throws Exception {
//ignore
}

connection.createStatement().executeUpdate("create table items (id integer, number integer, barcode varchar);");
connection.createStatement().executeUpdate("create table items (id integer, number integer, barcode varchar(10));");

connection.createStatement().executeUpdate("insert into items values(1, 1, '12345678');");

Expand Down
4 changes: 2 additions & 2 deletions core/modules/core/test/sample/services/ServicesTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ public void testBreakdownReport() throws Exception {
//ignore
}

connection.createStatement().executeUpdate("create table service (name varchar);");
connection.createStatement().executeUpdate("create table sold_item (service varchar, client varchar, volume integer, price decimal);");
connection.createStatement().executeUpdate("create table service (name varchar(50));");
connection.createStatement().executeUpdate("create table sold_item (service varchar(50), client varchar(50), volume integer, price decimal);");

connection.createStatement().executeUpdate("insert into service values('IT Support');");
connection.createStatement().executeUpdate("insert into service values('Technical support');");
Expand Down
2 changes: 1 addition & 1 deletion core/modules/core/test/utils/TestDatabase.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public void setUpDatabase() throws Exception {
} catch (SQLException e) {
//ignore
}
connection.createStatement().executeUpdate("create table user (login varchar, password varchar, create_ts timestamp);");
connection.createStatement().executeUpdate("create table user (login varchar(50), password varchar(50), create_ts timestamp);");
connection.createStatement().executeUpdate("insert into user (login, password, create_ts) values ('login1', 'passwd', TIMESTAMP '2050-01-01 00:00:00');");
connection.createStatement().executeUpdate("insert into user (login, password, create_ts) values ('login2', 'passwd', TIMESTAMP '2050-01-01 00:00:00');");
connection.createStatement().executeUpdate("insert into user (login, password, create_ts) values ('login3', 'passwd', TIMESTAMP '2050-01-01 00:00:00');");
Expand Down

0 comments on commit 9326fc0

Please sign in to comment.