Fixed naming and added javadoc

cuba-platform · Jul 6, 2021 · 48caf01 · 48caf01
1 parent 2ce6d99
commit 48caf01
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/core/modules/core/src/com/haulmont/yarg/formatters/impl/XlsxFormatter.java b/core/modules/core/src/com/haulmont/yarg/formatters/impl/XlsxFormatter.java
@@ -103,7 +103,7 @@ public void renderDocument() {
  findVerticalDependencies();
 
  result.clearWorkbook();
- result.excludeDefinedNames(rootBand);
+ result.clearBandDefinedNames(rootBand);
 
  for (BandData childBand : rootBand.getChildrenList()) {
  checkThreadInterrupted();

diff --git a/core/modules/core/src/com/haulmont/yarg/formatters/impl/xlsx/Document.java b/core/modules/core/src/com/haulmont/yarg/formatters/impl/xlsx/Document.java
@@ -281,7 +281,10 @@ public void clearWorkbook() {
  }
  }
 
- public void excludeDefinedNames(BandData rootBand) {
+ /**
+ * Method clears defined names associated with band data and leaves all other defined names in the workbook
+ */
+ public void clearBandDefinedNames(BandData rootBand) {
  workbook.getDefinedNames().getDefinedName().removeIf(
  ctDefinedName -> rootBand.findBandRecursively(ctDefinedName.getName()) != null
  );