Allowing external algo to find trigger patch #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing Codacy's "undefined loop variable" error.
nietootein
approved these changes
Jul 8, 2024
Prepping for new release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to interface with an external algo (i.e. DBScan) to find the trigger patch. Information must be written into a
csvfile containing theevent_id,obs_id,tel_id,trg_pixel_id(location; where the trigger happen via pixel_id), andtrg_waveform_sample_id(time; at which waveform sample the trigger happen). The csv files have to be located at the same directory as the input data with the same naming convention ending with 'npe.csv' instead of the standardr0.dl1.h5. The option to find the trigger patches from the true image or the integrated waveform is still possible.