Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0% minification #286

Closed
MohammadYounes opened this issue Mar 26, 2016 · 4 comments
Closed

0% minification #286

MohammadYounes opened this issue Mar 26, 2016 · 4 comments
Labels
improvement optimization

Comments

@MohammadYounes
Copy link

Zero percent length is left AS IS, which not only adds extra character but also messes N-Value syntax minification.

Input Actual Expected
margin:0% margin:0% margin:0
margin:0% 0px 0em 0rem margin:0% 0 0 margin:0

Thanks!
@MohammadYounes MohammadYounes changed the title 0% minifcation 0% minification Mar 26, 2016
RubaXa added a commit to RubaXa/csso that referenced this issue Oct 31, 2017
@RubaXa
css#286: Zero-value workaround for pading, margin and etc
38f8d03
RubaXa added a commit to RubaXa/csso that referenced this issue Nov 2, 2017
@RubaXa
css#286: convert zero-% to number
e445df6
RubaXa added a commit to RubaXa/csso that referenced this issue Nov 2, 2017
@RubaXa
css#286: Remove percent sign for zero-values percentages when safe
75ab9e1
lahmatiy pushed a commit that referenced this issue Nov 2, 2017
@RubaXa @lahmatiy
#286: Remove percent sign for zero-values percentages when safe (#363)
2fe96cc
@RubaXa
Copy link
Contributor

RubaXa commented Nov 2, 2017

@MohammadYounes done 🎉

@MohammadYounes
Copy link
Author

@RubaXa Thanks!

@lahmatiy
Copy link
Member

lahmatiy commented Nov 3, 2017

3.4.0 is out with this feature on board.

@lahmatiy lahmatiy closed this as completed Nov 3, 2017
@RubaXa
Copy link
Contributor

RubaXa commented Nov 3, 2017

@lahmatiy пятница же, спать надо, а не минор поднимать 🌝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lahmatiy @RubaXa @MohammadYounes