Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angle minimisation Firefox problem #229

Closed
jrencz opened this issue Apr 30, 2015 · 1 comment
Closed

Angle minimisation Firefox problem #229

jrencz opened this issue Apr 30, 2015 · 1 comment
Labels
duplicate

Comments

@jrencz
Copy link

jrencz commented Apr 30, 2015

Firefox des not seem to like 0 as angle in linear-gradient:

linear-gradient(0deg, #2B2B2B 1px, transparent 1px),  // valid
// After csso optimisation. 
linear-gradient(0, #2B2B2B 1px, transparent 1px); // invalid but treated as valid in Chrome and Safari. Not in Firefox.

It seems to angle has to have any unit.
Quick fix is to pass 360deg instead of 0deg but it's just a hack.
@joshbaumann joshbaumann mentioned this issue Aug 5, 2015
Merged
lahmatiy added a commit that referenced this issue Oct 7, 2015
@lahmatiy
Merge pull request #234 from Wizza/master
a3bd322 
Don't strip units off dimensions of non-length (issues #226, #229)
@lahmatiy
Copy link
Member

lahmatiy commented Oct 7, 2015

Fixed in 1.3.12

@lahmatiy lahmatiy closed this as completed Oct 7, 2015
@lahmatiy lahmatiy mentioned this issue Dec 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lahmatiy @jrencz