Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links to UDUNITS docs #147

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Fix broken links to UDUNITS docs #147

merged 2 commits into from
Apr 29, 2024

Conversation

mdpiper
Copy link
Member

@mdpiper mdpiper commented Apr 22, 2024

This PR updates links to the UDUNITS docs used in the BMI docs.

I also bumped the versions of the actions we use in the build-docs CI workflow.

This fixes #145 and #146.

@mdpiper
Copy link
Member Author

mdpiper commented Apr 22, 2024

@hellkite500 Would you mind reviewing this, please?

Copy link

@hellkite500 hellkite500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were the same references I found when I went digging, so should be good for now. How does this change ultimately get into https://bmi.readthedocs.io/en/stable/ so the links on the docs are valid?

@mdpiper
Copy link
Member Author

mdpiper commented Apr 22, 2024

How does this change ultimately get into https://bmi.readthedocs.io/en/stable/ so the links on the docs are valid?

I'll git cherry-pick the changes over to stable once they're merged.

@mdpiper mdpiper merged commit 2642b7a into develop Apr 29, 2024
2 checks passed
@mdpiper mdpiper deleted the mdpiper/fix-broken-links branch April 29, 2024 19:10
mdpiper added a commit that referenced this pull request Apr 29, 2024
* Fix broken links to UDUNITS docs

* Bump versions of checkout and setup-python actions

(cherry picked from commit 2642b7a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time units database link is broken
2 participants