sharestorageprovider: Stat resource when resolving share by path #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're already using a State based filter in the ListReceivedShares request. No need to manually check for that again.
When resolving a received shared by mountpath, make sure that the shared resource actually exists. This avoids issues with dangling shares for already delete resources using the same mountpoint. Fixes: owncloud/ocis#7895
2403905
reviewed
Mar 6, 2024
| @@ -261,7 +261,23 @@ var _ = Describe("Sharesstorageprovider", func() { | |||
| }, | |||
| } | |||
| default: | |||
| if req.Ref.ResourceId.OpaqueId == "shareddir-merged" { | |||
| switch req.Ref.ResourceId.OpaqueId { | |||
| case "shareddir", "shareddir2": | |||
There was a problem hiding this comment.
Do we need to provide the constants for the "shareddir", "shareddir2", "shareddir-merged"?
There was a problem hiding this comment.
Looking at the surrounding code, especially the outer switch statement, I'd say: no 😃
More seriously I guess the mocks could benefit from some refactoring, but I think the string constants are the least of on an issue.
2403905
approved these changes
Mar 7, 2024
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Mar 7, 2024
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Mar 7, 2024
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resolving a received shared by mountpath, make sure that the shared resource actually exists. This avoids issues with dangling shares for already delete resources using the same mountpoint.
Fixes: owncloud/ocis#7895